Fixed #30056 -- Added SQLite support for StdDev and Variance functions. #10783
Conversation
ngnpope
force-pushed
the
ticket-30056
branch
from
2b807f9
to
7c64787
Compare
ngnpope
force-pushed
the
ticket-30056
branch
from
7c64787
to
202b37d
Compare
|
For the future, please submit cleanups as separate PRs so they can be merged more easily. |
django/db/backends/sqlite3/base.py
Outdated
| @@ -49,6 +50,14 @@ def wrapper(*args, **kwargs): | |||
| return wrapper | |||
|
|
|||
|
|
|||
| def list_aggregate(function): | |||
| """ | |||
| Returns an aggregate class that accumulates values in a list and applies | |||
There was a problem hiding this comment.
Returns -> Return due to the PEP 257.
docs/releases/2.2.txt
Outdated
| @@ -333,6 +336,11 @@ backends. | |||
| ``DatabaseIntrospection.get_constraints()`` returns must be normalized by | |||
| ``identifier_converter()``. | |||
|
|
|||
| * ``DatabaseFeatures.supports_stddev`` has been removed. It was originally | |||
There was a problem hiding this comment.
Maybe has been removed -> is removed 🤔
There was a problem hiding this comment.
It seems this removal would only affect third party database backends that override it -- and if there are such backends, then it would seem to be an argument for keeping the feature, otherwise the backend must use some other hack to skip the test.
There was a problem hiding this comment.
I checked and none of the official 3rd-party-database-backends uses this feature.
docs/ref/models/querysets.txt
Outdated
| is available as an extension module for SQLite. Consult the `SQlite | ||
| documentation`_ for instructions on obtaining and installing this | ||
| extension. | ||
| Support was added for SQLite. |
There was a problem hiding this comment.
Based on the phrasing used in ref/contrib/gis/geoquerysets.txt... "SQLite support was added."
docs/releases/2.2.txt
Outdated
| @@ -333,6 +336,11 @@ backends. | |||
| ``DatabaseIntrospection.get_constraints()`` returns must be normalized by | |||
| ``identifier_converter()``. | |||
|
|
|||
| * ``DatabaseFeatures.supports_stddev`` has been removed. It was originally | |||
There was a problem hiding this comment.
It seems this removal would only affect third party database backends that override it -- and if there are such backends, then it would seem to be an argument for keeping the feature, otherwise the backend must use some other hack to skip the test.
timgraham
force-pushed
the
ticket-30056
branch
from
202b37d
to
9bfb0d6
Compare
timgraham
force-pushed
the
ticket-30056
branch
from
9bfb0d6
to
83677fa
Compare
timgraham
changed the title
Ticket #30056.