Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Add support for tox (http://tox.testrun.org/) and Travis CI (http://travis-ci.org/) #110

Closed
wants to merge 2 commits into from

4 participants

Marc Abramowitz Danilo Bargen Jannis Leidel Florian Apolloner
Marc Abramowitz

You might want to cherry-pick around the Travis commit if you think http://ci.django-cms.org/ is good enough and Travis doesn't add anything. Arguably, having more testing is better. OTOH, arguably having two build systems that yell at you when something breaks could be annoying.

As an example, here's the build status for my fork: Build Status -- http://travis-ci.org/msabramo/django

Tox is pretty neat though because you can run it on your local tree on uncommitted stuff, so you can catch errors before you push them and have the builds fail.

Danilo Bargen
dbrgn commented June 05, 2012

+1 for Travis support!

Florian Apolloner apollo13 commented on the diff June 09, 2012
... ...
@@ -0,0 +1,12 @@
  1
+# Tox (http://tox.testrun.org/) is a tool for running tests
  2
+# in multiple virtualenvs. This configuration file will run the
  3
+# test suite on all supported python versions. To use it, "pip install tox"
  4
+# and then run "tox" from this directory.
  5
+
  6
+[tox]
  7
+envlist = py26, py27
4
Florian Apolloner Owner
apollo13 added a note June 09, 2012

Does tox support pypy? if yes adding it here might make sense.

Marc Abramowitz
msabramo added a note June 10, 2012

tox does support pypy but whenever I've tried it on my Mac (OS X 10.6.8), the Django test suite shows a few errors and eventually hangs -- if we can figure out why and solve that, then I think it makes sense to add it back.

My version of pypy is:

Python 2.7.2 (0e28b379d8b3, Feb 09 2012, 18:31:14)
[PyPy 1.8.0 with GCC 4.2.1] on darwin

By the way, the envlist is just the default set of environments to use when tox is run with no arguments. You can still test with pypy by doing tox -e pypy. Once that works, we can add pypy to envlist.

Florian Apolloner Owner
apollo13 added a note June 10, 2012

Yes, Django forces pypy 1.8 into an endless loop somewhere, if you could test it with pypy 1.9 that would be awesome!

Marc Abramowitz
msabramo added a note June 11, 2012

With pypy 1.9 the test suite completes with a handful of errors. Any idea why these happen?

https://gist.github.com/2911138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Jannis Leidel
Owner
jezdez commented July 02, 2012

I disagree that both tox and Travis needs to be added. There is just too big overlap between the tools when it comes to test matrix setup. Given the fact we now can and should use pull requests it's also much easier to rely on the fact that contributors can rely on the fact that the @travisbot will inform the contributor of any test failures.

Jannis Leidel jezdez closed this July 02, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
1  .gitignore
@@ -2,3 +2,4 @@
2 2
 *.pot
3 3
 *.py[co]
4 4
 docs/_build/
  5
+.tox
9  .travis.yml
... ...
@@ -0,0 +1,9 @@
  1
+language: python
  2
+
  3
+python:
  4
+  - 2.6
  5
+  - 2.7
  6
+
  7
+script:
  8
+  - python setup.py install
  9
+  - cd tests && python runtests.py --settings=test_sqlite
12  tox.ini
... ...
@@ -0,0 +1,12 @@
  1
+# Tox (http://tox.testrun.org/) is a tool for running tests
  2
+# in multiple virtualenvs. This configuration file will run the
  3
+# test suite on all supported python versions. To use it, "pip install tox"
  4
+# and then run "tox" from this directory.
  5
+
  6
+[tox]
  7
+envlist = py26, py27
  8
+
  9
+[testenv]
  10
+changedir = {toxinidir}/tests
  11
+commands =
  12
+    {envpython} runtests.py --settings=test_sqlite
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.