Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add support for tox (http://tox.testrun.org/) and Travis CI (http://travis-ci.org/) #110

Closed
wants to merge 2 commits into from

4 participants

Marc Abramowitz Danilo Bargen Jannis Leidel Florian Apolloner
Marc Abramowitz

You might want to cherry-pick around the Travis commit if you think http://ci.django-cms.org/ is good enough and Travis doesn't add anything. Arguably, having more testing is better. OTOH, arguably having two build systems that yell at you when something breaks could be annoying.

As an example, here's the build status for my fork: Build Status -- http://travis-ci.org/msabramo/django

Tox is pretty neat though because you can run it on your local tree on uncommitted stuff, so you can catch errors before you push them and have the builds fail.

Danilo Bargen

+1 for Travis support!

Florian Apolloner apollo13 commented on the diff
@@ -0,0 +1,12 @@
+# Tox (http://tox.testrun.org/) is a tool for running tests
+# in multiple virtualenvs. This configuration file will run the
+# test suite on all supported python versions. To use it, "pip install tox"
+# and then run "tox" from this directory.
+
+[tox]
+envlist = py26, py27
Florian Apolloner Owner
apollo13 added a note

Does tox support pypy? if yes adding it here might make sense.

tox does support pypy but whenever I've tried it on my Mac (OS X 10.6.8), the Django test suite shows a few errors and eventually hangs -- if we can figure out why and solve that, then I think it makes sense to add it back.

My version of pypy is:

Python 2.7.2 (0e28b379d8b3, Feb 09 2012, 18:31:14)
[PyPy 1.8.0 with GCC 4.2.1] on darwin

By the way, the envlist is just the default set of environments to use when tox is run with no arguments. You can still test with pypy by doing tox -e pypy. Once that works, we can add pypy to envlist.

Florian Apolloner Owner

Yes, Django forces pypy 1.8 into an endless loop somewhere, if you could test it with pypy 1.9 that would be awesome!

With pypy 1.9 the test suite completes with a handful of errors. Any idea why these happen?

https://gist.github.com/2911138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Jannis Leidel
Owner

I disagree that both tox and Travis needs to be added. There is just too big overlap between the tools when it comes to test matrix setup. Given the fact we now can and should use pull requests it's also much easier to rely on the fact that contributors can rely on the fact that the @travisbot will inform the contributor of any test failures.

Jannis Leidel jezdez closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 4, 2012
  1. Marc Abramowitz
Commits on Jun 5, 2012
  1. Marc Abramowitz
This page is out of date. Refresh to see the latest.
Showing with 22 additions and 0 deletions.
  1. +1 −0  .gitignore
  2. +9 −0 .travis.yml
  3. +12 −0 tox.ini
1  .gitignore
View
@@ -2,3 +2,4 @@
*.pot
*.py[co]
docs/_build/
+.tox
9 .travis.yml
View
@@ -0,0 +1,9 @@
+language: python
+
+python:
+ - 2.6
+ - 2.7
+
+script:
+ - python setup.py install
+ - cd tests && python runtests.py --settings=test_sqlite
12 tox.ini
View
@@ -0,0 +1,12 @@
+# Tox (http://tox.testrun.org/) is a tool for running tests
+# in multiple virtualenvs. This configuration file will run the
+# test suite on all supported python versions. To use it, "pip install tox"
+# and then run "tox" from this directory.
+
+[tox]
+envlist = py26, py27
Florian Apolloner Owner
apollo13 added a note

Does tox support pypy? if yes adding it here might make sense.

tox does support pypy but whenever I've tried it on my Mac (OS X 10.6.8), the Django test suite shows a few errors and eventually hangs -- if we can figure out why and solve that, then I think it makes sense to add it back.

My version of pypy is:

Python 2.7.2 (0e28b379d8b3, Feb 09 2012, 18:31:14)
[PyPy 1.8.0 with GCC 4.2.1] on darwin

By the way, the envlist is just the default set of environments to use when tox is run with no arguments. You can still test with pypy by doing tox -e pypy. Once that works, we can add pypy to envlist.

Florian Apolloner Owner

Yes, Django forces pypy 1.8 into an endless loop somewhere, if you could test it with pypy 1.9 that would be awesome!

With pypy 1.9 the test suite completes with a handful of errors. Any idea why these happen?

https://gist.github.com/2911138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+
+[testenv]
+changedir = {toxinidir}/tests
+commands =
+ {envpython} runtests.py --settings=test_sqlite
Something went wrong with that request. Please try again.