Add support for tox (http://tox.testrun.org/) and Travis CI (http://travis-ci.org/) #110

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@msabramo

msabramo commented Jun 4, 2012

You might want to cherry-pick around the Travis commit if you think http://ci.django-cms.org/ is good enough and Travis doesn't add anything. Arguably, having more testing is better. OTOH, arguably having two build systems that yell at you when something breaks could be annoying.

As an example, here's the build status for my fork: Build Status -- http://travis-ci.org/msabramo/django

Tox is pretty neat though because you can run it on your local tree on uncommitted stuff, so you can catch errors before you push them and have the builds fail.

@dbrgn

This comment has been minimized.

Show comment
Hide comment
@dbrgn

dbrgn Jun 5, 2012

Contributor

+1 for Travis support!

Contributor

dbrgn commented Jun 5, 2012

+1 for Travis support!

+# and then run "tox" from this directory.
+
+[tox]
+envlist = py26, py27

This comment has been minimized.

@apollo13

apollo13 Jun 9, 2012

Member

Does tox support pypy? if yes adding it here might make sense.

@apollo13

apollo13 Jun 9, 2012

Member

Does tox support pypy? if yes adding it here might make sense.

This comment has been minimized.

@msabramo

msabramo Jun 10, 2012

tox does support pypy but whenever I've tried it on my Mac (OS X 10.6.8), the Django test suite shows a few errors and eventually hangs -- if we can figure out why and solve that, then I think it makes sense to add it back.

My version of pypy is:

Python 2.7.2 (0e28b379d8b3, Feb 09 2012, 18:31:14)
[PyPy 1.8.0 with GCC 4.2.1] on darwin

By the way, the envlist is just the default set of environments to use when tox is run with no arguments. You can still test with pypy by doing tox -e pypy. Once that works, we can add pypy to envlist.

@msabramo

msabramo Jun 10, 2012

tox does support pypy but whenever I've tried it on my Mac (OS X 10.6.8), the Django test suite shows a few errors and eventually hangs -- if we can figure out why and solve that, then I think it makes sense to add it back.

My version of pypy is:

Python 2.7.2 (0e28b379d8b3, Feb 09 2012, 18:31:14)
[PyPy 1.8.0 with GCC 4.2.1] on darwin

By the way, the envlist is just the default set of environments to use when tox is run with no arguments. You can still test with pypy by doing tox -e pypy. Once that works, we can add pypy to envlist.

This comment has been minimized.

@apollo13

apollo13 Jun 10, 2012

Member

Yes, Django forces pypy 1.8 into an endless loop somewhere, if you could test it with pypy 1.9 that would be awesome!

@apollo13

apollo13 Jun 10, 2012

Member

Yes, Django forces pypy 1.8 into an endless loop somewhere, if you could test it with pypy 1.9 that would be awesome!

This comment has been minimized.

@msabramo

msabramo Jun 11, 2012

With pypy 1.9 the test suite completes with a handful of errors. Any idea why these happen?

https://gist.github.com/2911138

@msabramo

msabramo Jun 11, 2012

With pypy 1.9 the test suite completes with a handful of errors. Any idea why these happen?

https://gist.github.com/2911138

@jezdez

This comment has been minimized.

Show comment
Hide comment
@jezdez

jezdez Jul 2, 2012

Member

I disagree that both tox and Travis needs to be added. There is just too big overlap between the tools when it comes to test matrix setup. Given the fact we now can and should use pull requests it's also much easier to rely on the fact that contributors can rely on the fact that the @travisbot will inform the contributor of any test failures.

Member

jezdez commented Jul 2, 2012

I disagree that both tox and Travis needs to be added. There is just too big overlap between the tools when it comes to test matrix setup. Given the fact we now can and should use pull requests it's also much easier to rely on the fact that contributors can rely on the fact that the @travisbot will inform the contributor of any test failures.

@jezdez jezdez closed this Jul 2, 2012

nanuxbe pushed a commit to nanuxbe/django that referenced this pull request Jul 2, 2016

nanuxbe pushed a commit to nanuxbe/django that referenced this pull request Jul 2, 2016

nanuxbe pushed a commit to nanuxbe/django that referenced this pull request Jul 2, 2016

nanuxbe pushed a commit to nanuxbe/django that referenced this pull request Jul 2, 2016

nanuxbe pushed a commit to nanuxbe/django that referenced this pull request Jul 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment