Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #29700 - Doc'd ModelAdmin.autocomplete_view() and AutocompleteJsonView. #11045

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@alexanderblnf
Copy link

commented Mar 2, 2019

…leteJsonView as customization point for ordering autocomplete results.

alexanderblnf
Ticket 29700 - Documented ModelAdmin.autocomplete_view() and Autocomp…
…leteJsonView as customization point for ordering autocomplete results.
@alexanderblnf

This comment has been minimized.

Copy link
Author

commented Mar 7, 2019

Hi @Parth1811 ! I see you've approved my PR. Is there anything else to be done, or is it good to merge?

@Parth1811

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

Hey @alexanderblnf I have approved this because I find the changes made by you are appropriate and don't raise any conflict, you have to wait till some contributor sees this and merges the branch or suggest few changes. You can also post it in django-developers group if it takes a long time

@timgraham

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

You should add a link to the PR and check "Has patch" on the ticket so that it appears in the review queue. I've just done that.

@timgraham timgraham changed the title Ticket 29700 - Documented ModelAdmin.autocomplete_view() and Autocomp… Fixed #29700 - Doc'd ModelAdmin.autocomplete_view() and AutocompleteJsonView. Mar 18, 2019

@alexanderblnf

This comment has been minimized.

Copy link
Author

commented Mar 21, 2019

@timgraham Thanks! Will do from now on

Show resolved Hide resolved docs/ref/contrib/admin/index.txt Outdated
@@ -2031,6 +2033,10 @@ templates used by the :class:`ModelAdmin` views:
Other methods
~~~~~~~~~~~~~

.. method:: ModelAdmin.autocomplete_view(request)

Django view for the page that shows the autocomplete results. See note below

This comment has been minimized.

Copy link
@timgraham

timgraham Mar 23, 2019

Member

What note below?

This comment has been minimized.

Copy link
@alexanderblnf

alexanderblnf Mar 24, 2019

Author

Right after defining all the methods in the Other methods section, there is a small note explaining that these views render the pages that deal with model instances CRUD operations. As a result, completely overriding these methods will significantly change the behavior of the admin application.. The same comment is added for almost all of the other methods in the section.

I agree it is debatable whether the below note applies to this view, as this is not a view that renders pages that handles CRUD operations. However, I consider at least the other half of the note to be applicable to this view as well (overriding this will change the behaviour of the admin page).

@timgraham, what's your take on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.