Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #30534 -- Fixed overriding a field's default in ModelForm.cleaned_data(). #11433

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
2 participants
@RobertAKARobin
Copy link
Contributor

commented May 31, 2019

…OSTed

@felixxm
Copy link
Member

left a comment

@RobertAKARobin Thanks for this patch 👍 I left some comments.

Show resolved Hide resolved django/forms/models.py Outdated
Show resolved Hide resolved tests/model_forms/tests.py Outdated
Show resolved Hide resolved tests/model_forms/tests.py Outdated
Show resolved Hide resolved tests/model_forms/tests.py Outdated

@felixxm felixxm self-assigned this Jun 3, 2019

@felixxm felixxm changed the title Fixed #30534 -- ModelForms: Can set cleaned_data[field] that is not P… Fixed #30534 -- Fixed overriding a field's default in ModelForm.cleaned_data(). Jun 3, 2019

@RobertAKARobin RobertAKARobin force-pushed the RobertAKARobin:ticket_30534 branch from 052ef1d to 5368565 Jun 3, 2019

@felixxm felixxm force-pushed the RobertAKARobin:ticket_30534 branch from 5368565 to aa94f7c Jun 4, 2019

@felixxm felixxm merged commit aa94f7c into django:master Jun 4, 2019

19 checks passed

docs Build #299 ended
Details
flake8 Build #299 ended
Details
isort Build #304 succeeded in 26 sec
Details
pr-mariadb/database=mysql,label=mariadb,python=python3.7 Build #297 ended
Details
pr-mariadb/database=mysql_gis,label=mariadb,python=python3.7 Build #297 ended
Details
pull-requests-bionic/database=mysql,label=bionic-pr,python=python3.6 Build #300 ended
Details
pull-requests-bionic/database=mysql,label=bionic-pr,python=python3.7 Build #300 ended
Details
pull-requests-bionic/database=mysql_gis,label=bionic-pr,python=python3.6 Build #300 ended
Details
pull-requests-bionic/database=mysql_gis,label=bionic-pr,python=python3.7 Build #300 ended
Details
pull-requests-bionic/database=postgis,label=bionic-pr,python=python3.6 Build #300 ended
Details
pull-requests-bionic/database=postgis,label=bionic-pr,python=python3.7 Build #300 ended
Details
pull-requests-bionic/database=postgres,label=bionic-pr,python=python3.6 Build #300 ended
Details
pull-requests-bionic/database=postgres,label=bionic-pr,python=python3.7 Build #300 ended
Details
pull-requests-bionic/database=spatialite,label=bionic-pr,python=python3.6 Build #300 ended
Details
pull-requests-bionic/database=spatialite,label=bionic-pr,python=python3.7 Build #300 ended
Details
pull-requests-bionic/database=sqlite3,label=bionic-pr,python=python3.6 Build #300 ended
Details
pull-requests-bionic/database=sqlite3,label=bionic-pr,python=python3.7 Build #300 ended
Details
pull-requests-javascript Build #302 ended
Details
pull-requests-windows/database=sqlite3,label=windows,python=Python37 Build #300 ended
Details
@felixxm

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

@RobertAKARobin Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.