Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #30010 -- Doc'd running tests with django-docker-box. #11838

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@KatherineMichel
Copy link
Contributor

KatherineMichel commented Sep 27, 2019

Per conversation with Carlton during Django sprint at DjangoCon US, added Django Docker Box to unit testing docs. Closes #30010

@KatherineMichel KatherineMichel changed the title Ticket 30010 Fixed #30010 - Added Django Docker Box to unit testing docs Sep 27, 2019
Copy link
Member

felixxm left a comment

@KatherineMichel Thanks for this patch 👍 I left small comments.

@felixxm felixxm changed the title Fixed #30010 - Added Django Docker Box to unit testing docs Fixed #30010 -- Doc'd running tests with django-docker-box. Sep 27, 2019
@felixxm

This comment has been minimized.

Copy link
Member

felixxm commented Oct 2, 2019

@KatherineMichel Do you have time to update your patch? If not I can push these minor edits for you.

@felixxm felixxm changed the title Fixed #30010 -- Doc'd running tests with django-docker-box. Refs #30010 -- Doc'd running tests with django-docker-box. Oct 2, 2019
@KatherineMichel

This comment has been minimized.

Copy link
Contributor Author

KatherineMichel commented Oct 2, 2019

@felixxm

This comment has been minimized.

Copy link
Member

felixxm commented Oct 2, 2019

@KatherineMichel Thanks! will do.

@felixxm

This comment has been minimized.

Copy link
Member

felixxm commented Oct 2, 2019

@KatherineMichel Done, thanks again 👍 Welcome aboard ⛵️ safe travels.

@felixxm felixxm merged commit f7eb9fb into django:master Oct 2, 2019
19 checks passed
19 checks passed
docs Build #2081 ended
Details
flake8 Build #2080 ended
Details
isort Build #2084 succeeded in 28 sec
Details
pr-mariadb/database=mysql,label=mariadb,python=python3.7 Build #2068 ended
Details
pr-mariadb/database=mysql_gis,label=mariadb,python=python3.7 Build #2068 ended
Details
pull-requests-bionic/database=mysql,label=bionic-pr,python=python3.6 Build #2120 ended
Details
pull-requests-bionic/database=mysql,label=bionic-pr,python=python3.7 Build #2120 ended
Details
pull-requests-bionic/database=mysql_gis,label=bionic-pr,python=python3.6 Build #2120 ended
Details
pull-requests-bionic/database=mysql_gis,label=bionic-pr,python=python3.7 Build #2120 ended
Details
pull-requests-bionic/database=postgis,label=bionic-pr,python=python3.6 Build #2120 ended
Details
pull-requests-bionic/database=postgis,label=bionic-pr,python=python3.7 Build #2120 ended
Details
pull-requests-bionic/database=postgres,label=bionic-pr,python=python3.6 Build #2120 ended
Details
pull-requests-bionic/database=postgres,label=bionic-pr,python=python3.7 Build #2120 ended
Details
pull-requests-bionic/database=spatialite,label=bionic-pr,python=python3.6 Build #2120 ended
Details
pull-requests-bionic/database=spatialite,label=bionic-pr,python=python3.7 Build #2120 ended
Details
pull-requests-bionic/database=sqlite3,label=bionic-pr,python=python3.6 Build #2120 ended
Details
pull-requests-bionic/database=sqlite3,label=bionic-pr,python=python3.7 Build #2120 ended
Details
pull-requests-javascript Build #2085 ended
Details
pull-requests-windows/database=sqlite3,label=windows,python=Python37 Build #2073 ended
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.