Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #30010 -- Doc'd running tests with django-docker-box. #11838

Merged
merged 1 commit into from Oct 2, 2019
Merged

Refs #30010 -- Doc'd running tests with django-docker-box. #11838

merged 1 commit into from Oct 2, 2019

Conversation

@KatherineMichel
Copy link
Contributor

@KatherineMichel KatherineMichel commented Sep 27, 2019

Per conversation with Carlton during Django sprint at DjangoCon US, added Django Docker Box to unit testing docs. Closes #30010

@KatherineMichel KatherineMichel changed the title Ticket 30010 Fixed #30010 - Added Django Docker Box to unit testing docs Sep 27, 2019
Copy link
Member

@felixxm felixxm left a comment

@KatherineMichel Thanks for this patch 👍 I left small comments.

docs/internals/contributing/writing-code/unit-tests.txt Outdated Show resolved Hide resolved
docs/internals/contributing/writing-code/unit-tests.txt Outdated Show resolved Hide resolved
docs/internals/contributing/writing-code/unit-tests.txt Outdated Show resolved Hide resolved
@felixxm felixxm changed the title Fixed #30010 - Added Django Docker Box to unit testing docs Fixed #30010 -- Doc'd running tests with django-docker-box. Sep 27, 2019
@felixxm
Copy link
Member

@felixxm felixxm commented Oct 2, 2019

@KatherineMichel Do you have time to update your patch? If not I can push these minor edits for you.

@felixxm felixxm changed the title Fixed #30010 -- Doc'd running tests with django-docker-box. Refs #30010 -- Doc'd running tests with django-docker-box. Oct 2, 2019
@KatherineMichel
Copy link
Contributor Author

@KatherineMichel KatherineMichel commented Oct 2, 2019

@felixxm
Copy link
Member

@felixxm felixxm commented Oct 2, 2019

@KatherineMichel Thanks! will do.

@felixxm
Copy link
Member

@felixxm felixxm commented Oct 2, 2019

@KatherineMichel Done, thanks again 👍 Welcome aboard safe travels.

@felixxm felixxm merged commit f7eb9fb into django:master Oct 2, 2019
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants