Trac #17181 - Allow for specifying multiple locales and domains for makemessages and compilemessages commands #121

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
4 participants
@jakul
Contributor

jakul commented Jun 7, 2012

option to pass in multiple locales to the compilemessages command, and multiple locales and multiple domains to the makemessages command

https://code.djangoproject.com/ticket/17181

I've updated the existing patch (from the ticket), so that it applies cleanly. I've added tests and docs.

Let me know if this is up to scratch!

allow multiple domains and languages for makemessages command; add op…
…tion to pass in multiple language to the compilemessages command
@claudep

This comment has been minimized.

Show comment
Hide comment
@claudep

claudep Jun 7, 2012

Member

There are already tests in tests/regressiontests/i18n/commands/compilation.py and tests/regressiontests/i18n/commands/extraction.py. You shouldn't create new test files.

Member

claudep commented Jun 7, 2012

There are already tests in tests/regressiontests/i18n/commands/compilation.py and tests/regressiontests/i18n/commands/extraction.py. You shouldn't create new test files.

@jakul

This comment has been minimized.

Show comment
Hide comment
@jakul

jakul Jun 7, 2012

Contributor

Merged the changes into the existing files; I also changed one of the tests to not use the it locale, which is used by some other tests

Contributor

jakul commented Jun 7, 2012

Merged the changes into the existing files; I also changed one of the tests to not use the it locale, which is used by some other tests

@apollo13

This comment has been minimized.

Show comment
Hide comment
@apollo13

apollo13 Jun 9, 2012

Member

I'd like to be able to use -l de -l en -l es as alternate for -l de,en,es to stay consistent with -n of startproject. The patch is also missing versionadded/changed directives.

Member

apollo13 commented Jun 9, 2012

I'd like to be able to use -l de -l en -l es as alternate for -l de,en,es to stay consistent with -n of startproject. The patch is also missing versionadded/changed directives.

@jakul

This comment has been minimized.

Show comment
Hide comment
@jakul

jakul Jun 13, 2012

Contributor

@apollo13 I've added the versionchanged directives. The patch already supported specifiying multiple locales through "-l de -l pt -l it"

Contributor

jakul commented Jun 13, 2012

@apollo13 I've added the versionchanged directives. The patch already supported specifiying multiple locales through "-l de -l pt -l it"

@apollo13

This comment has been minimized.

Show comment
Hide comment
@apollo13

apollo13 Jun 17, 2012

Member

Could you squash those commits into one? Btw do we really need tests/regressiontests/i18n/commands/locale/hr/LC_MESSAGES/django.po -- the locale folder there has already 3 existing locales, could you reuse those?

Member

apollo13 commented Jun 17, 2012

Could you squash those commits into one? Btw do we really need tests/regressiontests/i18n/commands/locale/hr/LC_MESSAGES/django.po -- the locale folder there has already 3 existing locales, could you reuse those?

@jakul

This comment has been minimized.

Show comment
Hide comment
@jakul

jakul Jun 20, 2012

Contributor

I need 2 locales with .po files and without .mo files in order to check that the compilation works properly.

Of the existing locales:
'it' has an error in the .po file and doesn't compile to a .mo file (this is intentional)
'fr' already has a commited .mo file

I can remove the hr locale if it is OK to remove the .mo file from the fr locale, however I didn't think that was a good thing to do.

Contributor

jakul commented Jun 20, 2012

I need 2 locales with .po files and without .mo files in order to check that the compilation works properly.

Of the existing locales:
'it' has an error in the .po file and doesn't compile to a .mo file (this is intentional)
'fr' already has a commited .mo file

I can remove the hr locale if it is OK to remove the .mo file from the fr locale, however I didn't think that was a good thing to do.

@ramiro

This comment has been minimized.

Show comment
Hide comment
@ramiro

ramiro Jan 18, 2013

Member

Closing, adapted and committed code from this PR in 6158c79. See https://code.djangoproject.com/ticket/17181#comment:9 for further details.

Thanks!

Member

ramiro commented Jan 18, 2013

Closing, adapted and committed code from this PR in 6158c79. See https://code.djangoproject.com/ticket/17181#comment:9 for further details.

Thanks!

@ramiro ramiro closed this Jan 18, 2013

nanuxbe pushed a commit to nanuxbe/django that referenced this pull request Jul 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment