Warn that `request_finished` is not sent under certain conditions #1238

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@jaap3
Contributor

jaap3 commented Jun 3, 2013

Older versions of uWSGI and Sentry's middleware do not adhere to
the WSGI spec and cause the request_finished signal to never
fire. Added notes to the appropriate places in the docs.

Trac ticket: 20537

Jaap Roes
Warn that `request_finished` is not sent under certain conditions
Older versions of uWSGI and Sentry's middleware do not adhere to
the WSGI spec and cause the `request_finished` signal to never
fire. Added notes to the appropriate places in the docs.

Trac ticket: 20537
+
+.. note::
+
+ There's WSGI middleware out there that does not call ``close`` on the

This comment has been minimized.

@timgraham

timgraham Jun 12, 2013

Member

"There's WSGI middleware out there that" -> "Some third-party WSGI middleware do not"

@timgraham

timgraham Jun 12, 2013

Member

"There's WSGI middleware out there that" -> "Some third-party WSGI middleware do not"

@aaugustin

This comment has been minimized.

Show comment
Hide comment
@aaugustin

aaugustin Jun 12, 2013

Member

Merged in 3ce1d30, thank you.

Member

aaugustin commented Jun 12, 2013

Merged in 3ce1d30, thank you.

@aaugustin aaugustin closed this Jun 12, 2013

@jaap3 jaap3 deleted the jaap3:ticket-20537 branch Nov 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment