New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #18134 -- BoundField.label_tag now includes the form's label_suffix #1252

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@timgraham
Member

timgraham commented Jun 7, 2013

There was an inconsistency between how the label_tag for forms were
generated depending on which method was used: as_p, as_ul and as_table
contained code to append the label_suffix where as label_tag called on a
form field directly did NOT append the label_suffix. The code for
appending the label_suffix has been moved in to the label_tag code of
the field and the HTML generation code for as_p, as_ul and as_table now
calls this code as well. This is a backwards incompatible change because
users who have added the label_suffix manually in their templates may now
get double label_suffix characters in their forms.

Updated version of #141

Fixed #18134 -- BoundField.label_tag now includes the form's label_su…
…ffix

There was an inconsistency between how the label_tag for forms were
generated depending on which method was used: as_p, as_ul and as_table
contained code to append the label_suffix where as label_tag called on a
form field directly did NOT append the label_suffix. The code for
appending the label_suffix has been moved in to the label_tag code of
the field and the HTML generation code for as_p, as_ul and as_table now
calls this code as well. This is a backwards incompatible change because
users who have added the label_suffix manually in their templates may now
get double label_suffix characters in their forms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment