Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed #20593 -- Allow blank passwords in check_password() and set_password() #1278

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Member

mxsasha commented Jun 17, 2013

No description provided.

@mxsasha mxsasha commented on the diff Jun 17, 2013

django/contrib/auth/hashers.py
@@ -47,7 +47,7 @@ def check_password(password, encoded, setter=None, preferred='default'):
If setter is specified, it'll be called when you need to
regenerate the password.
"""
- if not password or not is_password_usable(encoded):
+ if not is_password_usable(encoded):
@mxsasha

mxsasha Jun 17, 2013

Member

Note that is_password_usable() already checks whether password is None, so the double check that used to be here was obsolete anyways.

Owner

timgraham commented Jun 18, 2013

merged with minor doc tweaks in 2c4fe76, thanks!

@timgraham timgraham closed this Jun 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment