Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #31524 -- Removed minified static assets from the admin. #12821

Merged
merged 1 commit into from May 14, 2020
Merged

Fixed #31524 -- Removed minified static assets from the admin. #12821

merged 1 commit into from May 14, 2020

Conversation

jdufresne
Copy link
Member

@jdufresne jdufresne commented Apr 29, 2020 •
edited

carltongibson
carltongibson reviewed Apr 29, 2020
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jdufresne — just an initial comment: I think we need a release note (misc BC changes) just in case someone is explicitly referencing the minimized assets.

@carltongibson carltongibson self-requested a review April 29, 2020 07:03
@jdufresne
Copy link
Member Author

Thanks Carlton. I added a blurb to the release notes please let me know if it aligns with what you have in mind or if you have any wording suggestions.

@jdufresne
Copy link
Member Author

buildbot, test on selenium.

@jdufresne
Copy link
Member Author

I can reproduce the test failures locally. I will investigate them.

@jdufresne
Copy link
Member Author

buildbot, test on selenium.

@jdufresne
Copy link
Member Author

Test failures fixed.

@carltongibson
Copy link
Member

buildbot, test on selenium.

carltongibson
carltongibson approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good @jdufresne, thank you.

Separate to this, I think we could say a little bit in deployment.txt along on the lines of "compressing files gives you most of the benefits" but that's a different story... :)

Good stuff. 👍

@carltongibson carltongibson merged commit 81ffeda into django:master May 14, 2020
@jdufresne jdufresne deleted the no-compress-admin branch May 14, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jdufresne @carltongibson