Skip to content

Fixed #18056 - Cleared aggregations on DateQuery.add_date_select #132

Closed
wants to merge 1 commit into from

2 participants

@nmfm
nmfm commented Jun 8, 2012

Cleared aggregations on add_date_select method so only distinct dates are returned when dealing
with a QuerySet that contained aggregations. That would cause the query set to return repeated
dates because it would look for distinct (date kind, aggregation) pairs.

Tests pass on sqllite.

@nmfm nmfm Fixed #18056 - Cleared aggregations on DateQuery.add_date_select
Cleared aggregations on add_date_select method so only distinct dates are returned when dealing
with a QuerySet that contained aggregations. That would cause the query set to return repeated
dates because it would look for distinct (date kind, aggregation) pairs.
f5a7a64
@akaariai
Django member

Pushed in manually in commit bebbbb7

A few minor notes for future:

  • check for whitespace errors (git diff --check is very useful here).
  • avoid docstrings containing lines longer than 80 chars.

Thanks for the patch!

@akaariai akaariai closed this Jul 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.