Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed #20619 -- Refactored HttpRequest and WSGIRequest. #1335

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Member

loic commented Jul 6, 2013

No description provided.

Member

alex commented Jul 6, 2013

Now that Djanog is 100% WSGI, is there any reason to have separate HttpRequest and WSGIRequest classes?

Member

loic commented Jul 6, 2013

@alex: good question.

IMO the refactored HttpRequest class is lightweight and makes it easy to hack the public API. I don't mind keeping the hacks required for WSGI support bundled in their own class.

There might be a backward compatibility issue as well; some people may run custom handlers with an HttpRequest subclass in the wild.

@loic loic closed this Jul 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment