Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #32013 -- Added backward incompatibility note about ModelChoiceIterator changes. #13430

Merged
merged 1 commit into from Sep 21, 2020
Merged

Refs #32013 -- Added backward incompatibility note about ModelChoiceIterator changes. #13430

merged 1 commit into from Sep 21, 2020

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Sep 17, 2020

carltongibson
carltongibson approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine.

In might be tempted to add a In most cases this proxies transparently but, if you need.. but maybe that’s saying too much?

@jaap3
Copy link
Contributor

jaap3 commented Sep 17, 2020

In my opinion the additional note about transparently proxying comparisons (and str (others?)) would be welcome. If not here, then maybe on the docs for ModelChoiceIteratorValue? It would've helped me reason about the other .choices manipulating code I mentioned in ticket-32013.

@carltongibson
Copy link
Member

@jaap3 Fancy suggesting a change to this https://docs.djangoproject.com/en/3.1/ref/forms/fields/#modelchoiceiteratorvalue ?

@felixxm
Copy link
Member Author

felixxm commented Sep 17, 2020

Thanks both 🚀

jdufresne
jdufresne approved these changes Sep 19, 2020
View reviewed changes
Copy link
Member

@jdufresne jdufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all for the report and doc clarification.

@felixxm felixxm changed the title Refs #32013 -- Added backward incompatibility note ModelChoiceIterator changes. Refs #32013 -- Added backward incompatibility note about ModelChoiceIterator changes. Sep 21, 2020
@felixxm felixxm merged commit ba6b32e into django:master Sep 21, 2020
@felixxm felixxm deleted the refs-32013 branch September 21, 2020 04:25
@jaap3
Copy link
Contributor

jaap3 commented Sep 21, 2020

Thanks everyone 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson approved these changes

@jdufresne jdufresne jdufresne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@felixxm @jaap3 @carltongibson @jdufresne