Fixed #18444 -- Replace hard coded "View on Site" URLs #137

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@dhepper
Contributor

dhepper commented Jun 8, 2012

@mjtamlyn

This comment has been minimized.

Show comment
Hide comment
@mjtamlyn

mjtamlyn Jun 8, 2012

Member

👍

Member

mjtamlyn commented Jun 8, 2012

👍

@dbrgn

This comment has been minimized.

Show comment
Hide comment
@dbrgn

dbrgn Jun 9, 2012

Contributor

Looks OK to me.

Contributor

dbrgn commented Jun 9, 2012

Looks OK to me.

@apollo13

This comment has been minimized.

Show comment
Hide comment
@apollo13

apollo13 Jun 9, 2012

Member

I personally would rename shortcut to something like object_shortcut.

Member

apollo13 commented Jun 9, 2012

I personally would rename shortcut to something like object_shortcut.

@apollo13

This comment has been minimized.

Show comment
Hide comment
@apollo13

apollo13 Jun 9, 2012

Member

Aren't the jsi18n changes covered in #139 ?

Member

apollo13 commented Jun 9, 2012

Aren't the jsi18n changes covered in #139 ?

@dhepper

This comment has been minimized.

Show comment
Hide comment
@dhepper

dhepper Jun 9, 2012

Contributor

@apollo13 you are right, that was not intended. I removed the commit from the branch and updated with a forced push

Contributor

dhepper commented Jun 9, 2012

@apollo13 you are right, that was not intended. I removed the commit from the branch and updated with a forced push

@jphalip

This comment has been minimized.

Show comment
Hide comment
@jphalip

jphalip Jun 16, 2012

Member

That looks good to me. I'd just rename the url to 'view_on_site'.

Member

jphalip commented Jun 16, 2012

That looks good to me. I'd just rename the url to 'view_on_site'.

@apollo13 apollo13 closed this Jun 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment