Skip to content

Fixed #18444 -- Replace hard coded "View on Site" URLs #137

Closed
wants to merge 1 commit into from

5 participants

@mjtamlyn
Django member
mjtamlyn commented Jun 8, 2012

:+1:

@dbrgn
dbrgn commented Jun 9, 2012

Looks OK to me.

@apollo13
Django member
apollo13 commented Jun 9, 2012

I personally would rename shortcut to something like object_shortcut.

@apollo13
Django member
apollo13 commented Jun 9, 2012

Aren't the jsi18n changes covered in #139 ?

@dhepper
dhepper commented Jun 9, 2012

@apollo13 you are right, that was not intended. I removed the commit from the branch and updated with a forced push

@jphalip
Django member
jphalip commented Jun 16, 2012

That looks good to me. I'd just rename the url to 'view_on_site'.

@apollo13 apollo13 closed this Jun 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.