Fixed #5335 -- Changed ErrorDict to be a subclass of defaultdict. #1481

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@loic
Member
loic commented Aug 16, 2013

No description provided.

@timgraham timgraham and 1 other commented on an outdated diff Aug 20, 2013
docs/ref/forms/validation.txt
-extra design effort to create a sensible form display. The details are worth
-noting, however. Firstly, earlier we mentioned that you might need to check if
-the field name keys already exist in the ``_errors`` dictionary. In this case,
-since we know the fields exist in ``self.cleaned_data``, they must have been
-valid when cleaned as individual fields, so there will be no corresponding
-entries in ``_errors``.
-
-Secondly, once we have decided that the combined data in the two fields we are
-considering aren't valid, we must remember to remove them from the
-``cleaned_data``. `cleaned_data`` is present even if the form doesn't
-validate, but it contains only field values that did validate.
+extra design effort to create a sensible form display. Once we have decided
+that the combined data in the two fields we are considering aren't valid, we
+must remember to remove them from the ``cleaned_data``.
+
+.. versionchanged:: 1.5
@timgraham
timgraham Aug 20, 2013 Member

I think you resolved a merge conflict incorrectly. "versionchanged:: 1.5" annotations have been removed in master.

@loic
loic Aug 20, 2013 Member

Indeed, I thought it was an artifact from the rewind.

@mjtamlyn
Member

Closed as discussed on ticket and ML - the main reason being that defaultdicts don't behave nicely with templates.

@mjtamlyn mjtamlyn closed this Aug 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment