Skip to content

Fixed #33178 -- Made createsuperuser validate required fields passed in options in interactive mode. - #14960

Merged
felixxm merged 2 commits into
django:mainfrom
christophehenry:fix-33178
Oct 12, 2021
Merged

Fixed #33178 -- Made createsuperuser validate required fields passed in options in interactive mode.#14960
felixxm merged 2 commits into
django:mainfrom
christophehenry:fix-33178

Conversation

@christophehenry

@christophehenry christophehenry commented Oct 8, 2021

Copy link
Copy Markdown
Contributor

Fixes #33178: creratesuperuser does not validate REQUIRED_FIELDS fields value in interactive mode when passed by command-line

Comment thread tests/auth_tests/test_management.py Outdated

@felixxm felixxm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christophehenry Thanks for this patch 👍

Comment thread tests/auth_tests/test_management.py Outdated
Comment thread tests/auth_tests/test_management.py Outdated
Comment thread tests/auth_tests/test_management.py Outdated
Comment thread tests/auth_tests/test_management.py Outdated
Comment thread tests/auth_tests/test_management.py Outdated
Comment thread tests/auth_tests/test_management.py Outdated
Comment thread tests/auth_tests/test_management.py Outdated
Comment thread tests/auth_tests/test_management.py Outdated
Comment thread tests/auth_tests/test_management.py Outdated
Comment thread django/contrib/auth/management/commands/createsuperuser.py Outdated
Comment thread django/contrib/auth/management/commands/createsuperuser.py Outdated
@felixxm felixxm changed the title Fix #33178 -- Validate REQUIRED_FIELDS field value when passed from command-line Fixed #33178 -- Made createsuperuser validate required fields passed in options in interactive mode. Oct 12, 2021
@felixxm
felixxm merged commit b1b26b3 into django:main Oct 12, 2021
@christophehenry
christophehenry deleted the fix-33178 branch October 12, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants