Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed #18110 -- Improve template cache tag documentation #153

Merged
merged 1 commit into from Aug 4, 2012

Conversation

Projects
None yet
2 participants
Contributor

webjunkie commented Jun 14, 2012

For me it was not clear that the fragment name cannot be a variable. I just found out by wondering about errors and having a quick look into Django's code. It should be made more clear that the second argument will not be resolved even though all the others will be (even the cache time gets resolved).

"It takes at least two arguments: the cache timeout, in seconds, and the name to give the cache fragment. For example:"

should at least be something like

"It takes at least two arguments: the cache timeout, in seconds, and the name to give the cache fragment. The name will be taken as is, do not use a variable. For example:"

https://docs.djangoproject.com/en/dev/topics/cache/#template-fragment-caching

https://code.djangoproject.com/ticket/18110

timgraham added a commit that referenced this pull request Aug 4, 2012

Merge pull request #153 from webjunkie/patch-1
Fixed #18110 -- Improve template cache tag documentation

@timgraham timgraham merged commit 84c3c90 into django:master Aug 4, 2012

nanuxbe pushed a commit to nanuxbe/django that referenced this pull request Jul 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment