Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed #21126 - Properly align resolve_columns fields for aggregates #1646

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

manfre commented Sep 19, 2013

The 'row' passed to resolve_columns includes aggregate values, but
'fields' did not. This resulted in backends incorrectly aligning the
fields and values. 'fields' now includes None placeholders for each
aggregate value in the row.

Fixed #21126 - Properly align resolve_columns fields for aggregates
The 'row' passed to resolve_columns includes aggregate values, but
'fields' did not. This resulted in backends incorrectly aligning the
fields and values. 'fields' now includes None placeholders for each
aggregate value in the row.
Member

charettes commented Sep 19, 2013

I think we should test this. Can you provide a failing test case?

Member

charettes commented Sep 19, 2013

What's the difference between this PR and #1647?

Contributor

manfre commented Sep 19, 2013

The specifics of aggregate_select changed between Django 1.5 and 1.6. One pull for master and the other is for stable/1.5.X

Member

charettes commented Sep 19, 2013

Oops didn't see they were against different branches, my bad. Sill this needs tests.

Member

akaariai commented Sep 25, 2013

Fixed in 83554b0

@akaariai akaariai closed this Sep 25, 2013

@manfre manfre deleted the manfre:ticket-21126 branch Sep 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment