Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed #20364 -Added a passing test that confirms URLs in quotes followed by commas are handled correctly by Chris Piwoński's patch. #1662

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

augeas commented Sep 23, 2013

It has been suggested that the patch 20364.diff would not correctly handle a URL in quotes followed by a comma, but this is not the case.

https://code.djangoproject.com/ticket/20364

Owner

timgraham commented Sep 23, 2013

This should include the tests from kriestof/django@4dc7d8d as well.

Contributor

augeas commented Sep 24, 2013

Done. My solitary test now follows Chris Piwoński's. The tests deem defaultfilters healthy.

Contributor

evildmp commented Sep 24, 2013

I'm taking a look at this now.

@augeas augeas Fixed #20364 -Added a passing test to Chris Piwoński's set that confi…
…rms URLs in quotes followed by commas are handled correctly by his patch.

Thanks to EmilStenstrom for raising this, and to Chris Piwoński for all of the fixes and most of the tests.
Applied the urlize patch at: https://code.djangoproject.com/attachment/ticket/20364/20364.diff
Also merged the tests from: kriestof@4dc7d8d

 On branch grg-urlize-tests
        modified:   tests/defaultfilters/tests.py
	modified:   django/utils/html.py
9097956
Contributor

augeas commented Sep 25, 2013

Edited the commit message.

Owner

apollo13 commented Sep 25, 2013

Commited in 6c06ada, thank you!

@apollo13 apollo13 closed this Sep 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment