Fixed #20439 -- Started deprecation of IPAddressField #1688

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@erikr
Member
erikr commented Sep 28, 2013

No description provided.

@aaugustin aaugustin commented on the diff Sep 28, 2013
django/db/models/fields/__init__.py
@@ -1312,6 +1312,9 @@ class IPAddressField(Field):
description = _("IPv4 address")
def __init__(self, *args, **kwargs):
+ import warnings
@aaugustin
aaugustin Sep 28, 2013 Member

I prefer keeping imports at the top of modules.

@aaugustin aaugustin commented on the diff Sep 28, 2013
django/forms/fields.py
@@ -1144,6 +1144,12 @@ def compress(self, data_list):
class IPAddressField(CharField):
default_validators = [validators.validate_ipv4_address]
+ def __init__(self, *args, **kwargs):
+ import warnings
@aaugustin
aaugustin Sep 28, 2013 Member

Same as above.

@aaugustin aaugustin commented on the diff Sep 28, 2013
docs/releases/1.7.txt
@@ -529,3 +529,11 @@ to ``utils.py`` in an effort to unify all util and utils references:
``ModelAdmin.get_formsets`` has been deprecated in favor of the new
:meth:`~django.contrib.admin.ModelAdmin.get_formsets_with_inlines`, in order to
better handle the case of selecting showing inlines on a ``ModelAdmin``.
+
+``IPAddressField``
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@aaugustin
aaugustin Sep 28, 2013 Member

Underline is too long (Sphinx probably complains about it if you build the docs).

@aaugustin
Member

Merged in 1a63092.

@aaugustin aaugustin closed this Sep 28, 2013
@erikr erikr deleted the unknown repository branch Sep 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment