Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixed #17914 — reverse() does not support namespaced view references #174

Closed
wants to merge 70 commits into from
apollo13 and others added some commits
@apollo13 apollo13 Don't escape object ids when passing to the contenttypes.shortcut view.
This commit also changes the string pk to string_pk instead of id, to test
if the admin uses .pk throughout the codebase.
e1643e3
@aaugustin aaugustin Fixed #18445 -- Added a links in the docs.
Thanks Audrey Roy for the patch.
33999d9
@spookylukey spookylukey Small corrections to committing-code docs f269f30
@aaugustin aaugustin Fixed #18125 -- Explained caveat with filters
Thanks ebrelsford AT gmail.com and oinopion.
06ea10e
@aaugustin aaugustin Merge pull request #127 from dhepper/master
Fixed #18433 -- Fixed "View on Site" link in inline admin for models with custom PK

Thanks dhepper for the patch and apollo13 for the review.
c172951
@aaugustin aaugustin Merge pull request #123 from apollo13/ticket18381
Fixed #18381 -- Stopped escaping object ids

when passing them to the contenttypes.shortcut view.

Thanks apollo13 for the patch and dhepper for the review.
23d230f
@aaugustin aaugustin Proof-read the new contributing guide.
Many thanks to Daniele Procida.
329bb92
@aaugustin aaugustin Explained an alternative way to fetch a branch.
This avoids adding each contributor as a remote.

Thanks Fruneau for the report.
1f203f8
@aaugustin aaugustin Clarified the purpose of the pull requsets docs
One is for the community, the other for the core team.

Thanks Reinout van Rees for the report.
d2ad3b0
@audreyr audreyr Revised the text in the 'Using a form in a view' section. 3c05b50
@audreyr audreyr Revised the text in the 'Processing the data from a form' section. 7ab6e32
@aaugustin aaugustin Fixed an error in a git command. 7ae6651
@akaariai akaariai Added myself to committers 18aed86
@adrianholovaty adrianholovaty Fixed #18440 -- Pointed out that ReportLab is not thread safe. Thanks…
…, jens@lundstroem.com
c63c62a
@akaariai akaariai Used git log instead of git show for last commit's timestamp
The reason for this was that git show included the whole changeset in
the output, but only the UTC timestamp was needed. By using git log
it is possible to get just the timestamp. The whole changeset can be
large, and can cause unicode encoding errors.
9098504
@charettes charettes Fixed #18399 – Added a way to get ContentTypes for proxy models
Added kwargs for_concrete_model and for_concrete_models to ContentType
methods get_for_model() and get_for_models(). By setting the flag to
False, it is possible to get the contenttype for proxy models.
b6d533a
@akaariai akaariai Cleaned whitespace errors introduced in previous commit a035d9d
@akaariai akaariai Fixed #16418 -- Made generic views work with ModelForms
Generic views assumed any object's _meta will be model Options. This
is not true for ModelForms for example. Took isinstance(obj, Model)
in use instead.
484fcd3
@claudep claudep Fixed #17760 -- Implemented callable database features as cached prop…
…erties

This does remove the requirement to call features.confirm() method
before checking the properties.
Thanks cdestiger and Ramiro Morales for their work on the patch.
aa42357
@claudep claudep Reverted 905e33f, now that DatabaseFeatures does not need confirm
Connection.features does not need to be confirmed any more, after
commit aa42357, rendering obsolete the workaround when using
TEST_MIRROR (Refs #16885, #17760).
ad47364
@claudep claudep Removed test of connection features before setting up databases ef906b1
@claudep claudep Fixed #17159 -- Validated returned number of next|previous_page_number
Thanks mehta.apurva at gmail.com for the report and the initial patch
and neaf for the complete patch.
fc40a65
@claudep claudep Fixed pagination example wrt new next_page_number behavior 514e827
@claudep claudep Fixed #18157 -- Documented that setting PASSWORD_HASHERS can speed up…
… tests
17d6cd9
@claudep claudep Added note about including fixtures hashing algorithm
Refs #18157.
b0d8085
@spookylukey spookylukey Corrected way to get URL of object in admin history template e9497a3
@claudep claudep Fixed #18457 -- Fixed encoding error in yaml deserializer
Thanks jpaugh64 for the report.
1a10a06
@jezdez jezdez Fixed #18451 -- Vastly improved class based view documentation.
Many thanks to Daniel Greenfeld, James Aylett, Marc Tamlyn, Simon Williams, Danilo Bargen and Luke Plant for their work on this.
c4c7fbc
claudep and others added some commits
@claudep claudep Fixed #18463 -- Forced type() argument to be a byte string 3dd5d72
@claudep claudep Cleaned up locale-related encoding issues 35f9c2c
@claudep claudep Added missing encoding prefix in localflavor test a7ef802
@claudep claudep Fixed #18461 -- Ensured that last_executed_query returns Unicode
Thanks Anssi Kääriäinen for the review.
e9ef977
@akaariai akaariai Fixed connection.queries encoding handling on Oracle
In addition, removed a possibly problematic .filter() call from
backends.test_query_encoding test. It is possible the .filter could
cause collation problems on MySQL, and as it wasn't absolutely needed
for the test it seemed better to get rid of the call.

Refs #18461.
86c20e3
@claudep claudep Removed escaping test of query content
As the content of last_executed_query() is not under Django's control
for most backends, it is useless to test too specific aspects of it.
a2022da
@claudep claudep Fixed #12140 -- Fixed http.urlencode result for empty lists
Thanks aneil for the report and the initial patch.
fe873e2
@claudep claudep Fixed #17754 -- Refactored gis.measure
This refactoring does allow much easier MeasureBase subclassing.
Many thanks to Ricardo di Virgilio for the initial patch.
4d46106
@claudep claudep Discovered some geodjango tests with standard mechanism
No need to special case tests discovery for regular first-level
gis tests.
88601ba
@claudep claudep Executed SpatialRefSysTest only with spatial backend 023b704
@spookylukey spookylukey Reverted part of 169b1a4 which was mistakenly applied to a non-iterat…
…or class.

Doing next(IfParser()) works for Python 2.7, because it calls
IfParser.next(), but in Python 3 will call IfParser.__next__() which does
not work since it is not an iterator and does not have that method.
edee20f
@spookylukey spookylukey IfParser.next() method renamed to avoid confusion with iterator proto…
…col.
fd6a9d3
@claudep
Collaborator

Thanks Luke for fixing it and sorry for the confusion I made.

Collaborator
Collaborator

No, no, that's fine. That's collaborate work, isn't it? :-)

claudep and others added some commits
@claudep claudep Favored text (StringIO) over binary content for deserialization
This is also more Python 3 compatible, as the json module in
Python 3 is expecting text. Thanks Vinay Sajip for noticing it.
5bdd0d6
@jphalip jphalip Skip GeometryFieldTest if there's no spacial database. 1794e36
@jphalip jphalip Fixed #18477 -- Fixed colspan value when a TabularInline form contain…
…s validation errors. Thanks to yedpodtrzitko for the report and patch.
1ace912
@jphalip jphalip Fixed the path to the admin's compress.py script in the doc. 79ef390
@jphalip jphalip Updated the admin's minified JS files. fadcc6d
@jphalip jphalip Fixed #18420 -- Prevented the admin JS from crashing when the main fo…
…rm contains no field. Thanks to maciej.maciaszek for the report and patch.
d708298
@apollo13 apollo13 Fixed GIS testsuite.
Moved HAS_SPATIALREFSYS back into the tests namespace since it only operates
on the default database and isn't a global flag like HAS_GDAL.
ac1b9ae
@dhepper dhepper Fixed #18450 -- Removed default values for i18n JavaScript URLs in Ad…
…min templates
108f8dd
@dhepper dhepper Fixed #18444 -- Replace hard coded "View on Site" URLs aee9eec
@gabejackson gabejackson Fixed #18154 -- Documentation on closing File objects and best practices ffa6d95
@SmileyChris SmileyChris Fixed #14502 again -- saner verbatim closing token
Previously, the closing token for the verbatim tag was specified as the
first argument of the opening token. As pointed out by Jannis, this is
a rather major departure from the core tag standard.

The new method reflects how you can give a specific closing name to
{% block %} tags.
c57ba67
@tsaylor tsaylor Fixed a documentation typo on the widget page. f8ef93a
@dgerzo dgerzo Added support for gdal 1.9. 45a1a54
@claudep claudep Fixed #15271 -- Defined a to_python method for GeometryField
Thanks volrath and copelco for their work on the patch.
41eb70f
@claudep claudep Removed unneeded u prefixes f08fa5b
@spookylukey spookylukey Fixed #17776 - DoesNotExist is not picklable
Thanks to ambv for the report
a54a8ba
@apollo13 apollo13 Fixed our HTMLParser patches for python 2.7.4 6bc1b22
@apollo13 apollo13 Corrected the `instance_dict` description for form wizards. 7f22588
@alex alex Note that Jython has an alpha with 2.7 support. ea9536b
@jnns jnns Updated TEMPLATE_CONTEXT_PROCESSORS defaults in the docs.
django.core.context_processors.tz was missing from default
TEMPLATE_CONTEXT_PROCESSORS in the template api documentation.
c864b36
@bmihelac bmihelac Fixed url translation docs.
``include`` calls shouldn't have a $ sign at the end of the url pattern.
946d3d9
@dmedvinsky dmedvinsky Fixed #18454 -- Added ability to pass a list of signals to `receiver`.
Added ability to use receiver decorator in the following way:

    @receiver([post_save, post_delete], sender=MyModel)
    def signals_receiver(sender, **kwargs):
        ...
d4da083
@alex alex Don't use a list comprehension when we don't need the resulting list. e1b74d0
@alex alex Switch to using context managers for acquiring and releasing locks. e0fce87
@claudep claudep Fixed #14917 -- Hinted that view should redirect after form post success 19a810b
@claudep claudep Fixed #16317 -- Fixed dumpdata for self-referencing models and natura…
…l keys

Thanks aldaran for the patch.
4b722b3
@bradleyayers bradleyayers Add a test for #17914 74527ba
@bradleyayers bradleyayers Add support for reversing namespaced view references. e0cd450
@bradleyayers bradleyayers When reversing a view reference, choose the first occurrence in the U…
…RLconf rather than the last.
6e845ea
@bradleyayers bradleyayers Only propagate callables from resolver.reverse_dict to parents, rathe…
…r than everything.
079e93e
@Bouke

This PR has gotten quite polluted; could you update the PR to only include commits relevant to the ticket?

@timgraham
Owner

This PR needs to be reworked so it doesn't include unrelated commits (caused by when someone accidentally force pushed to (django/django)). There have also been a lot of changes in the last 2 years so the PR probably needs updating.

@timgraham timgraham closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 7, 2012
  1. @apollo13

    Don't escape object ids when passing to the contenttypes.shortcut view.

    apollo13 authored
    This commit also changes the string pk to string_pk instead of id, to test
    if the admin uses .pk throughout the codebase.
  2. @aaugustin

    Fixed #18445 -- Added a links in the docs.

    aaugustin authored
    Thanks Audrey Roy for the patch.
  3. @spookylukey
Commits on Jun 8, 2012
  1. @aaugustin

    Fixed #18125 -- Explained caveat with filters

    aaugustin authored
    Thanks ebrelsford AT gmail.com and oinopion.
  2. @aaugustin

    Merge pull request #127 from dhepper/master

    aaugustin authored
    Fixed #18433 -- Fixed "View on Site" link in inline admin for models with custom PK
    
    Thanks dhepper for the patch and apollo13 for the review.
  3. @aaugustin

    Merge pull request #123 from apollo13/ticket18381

    aaugustin authored
    Fixed #18381 -- Stopped escaping object ids
    
    when passing them to the contenttypes.shortcut view.
    
    Thanks apollo13 for the patch and dhepper for the review.
  4. @aaugustin

    Proof-read the new contributing guide.

    aaugustin authored
    Many thanks to Daniele Procida.
  5. @aaugustin

    Explained an alternative way to fetch a branch.

    aaugustin authored
    This avoids adding each contributor as a remote.
    
    Thanks Fruneau for the report.
  6. @aaugustin

    Clarified the purpose of the pull requsets docs

    aaugustin authored
    One is for the community, the other for the core team.
    
    Thanks Reinout van Rees for the report.
  7. @audreyr @aaugustin
  8. @audreyr @aaugustin
  9. @aaugustin
  10. @akaariai

    Added myself to committers

    akaariai authored
  11. @adrianholovaty
  12. @akaariai

    Used git log instead of git show for last commit's timestamp

    akaariai authored
    The reason for this was that git show included the whole changeset in
    the output, but only the UTC timestamp was needed. By using git log
    it is possible to get just the timestamp. The whole changeset can be
    large, and can cause unicode encoding errors.
  13. @charettes @akaariai

    Fixed #18399 – Added a way to get ContentTypes for proxy models

    charettes authored akaariai committed
    Added kwargs for_concrete_model and for_concrete_models to ContentType
    methods get_for_model() and get_for_models(). By setting the flag to
    False, it is possible to get the contenttype for proxy models.
  14. @akaariai
  15. @akaariai

    Fixed #16418 -- Made generic views work with ModelForms

    akaariai authored
    Generic views assumed any object's _meta will be model Options. This
    is not true for ModelForms for example. Took isinstance(obj, Model)
    in use instead.
Commits on Jun 9, 2012
  1. @claudep

    Fixed #17760 -- Implemented callable database features as cached prop…

    claudep authored
    …erties
    
    This does remove the requirement to call features.confirm() method
    before checking the properties.
    Thanks cdestiger and Ramiro Morales for their work on the patch.
  2. @claudep

    Reverted 905e33f, now that DatabaseFeatures does not need confirm

    claudep authored
    Connection.features does not need to be confirmed any more, after
    commit aa42357, rendering obsolete the workaround when using
    TEST_MIRROR (Refs #16885, #17760).
  3. @claudep
  4. @claudep

    Fixed #17159 -- Validated returned number of next|previous_page_number

    claudep authored
    Thanks mehta.apurva at gmail.com for the report and the initial patch
    and neaf for the complete patch.
  5. @claudep
  6. @claudep
  7. @claudep
Commits on Jun 10, 2012
  1. @spookylukey
  2. @claudep

    Fixed #18457 -- Fixed encoding error in yaml deserializer

    claudep authored
    Thanks jpaugh64 for the report.
Commits on Jun 11, 2012
  1. @jezdez

    Fixed #18451 -- Vastly improved class based view documentation.

    jezdez authored
    Many thanks to Daniel Greenfeld, James Aylett, Marc Tamlyn, Simon Williams, Danilo Bargen and Luke Plant for their work on this.
  2. @claudep
Commits on Jun 12, 2012
  1. @claudep
  2. @claudep
Commits on Jun 13, 2012
  1. @claudep

    Fixed #18461 -- Ensured that last_executed_query returns Unicode

    claudep authored
    Thanks Anssi Kääriäinen for the review.
  2. @akaariai

    Fixed connection.queries encoding handling on Oracle

    akaariai authored
    In addition, removed a possibly problematic .filter() call from
    backends.test_query_encoding test. It is possible the .filter could
    cause collation problems on MySQL, and as it wasn't absolutely needed
    for the test it seemed better to get rid of the call.
    
    Refs #18461.
  3. @claudep

    Removed escaping test of query content

    claudep authored
    As the content of last_executed_query() is not under Django's control
    for most backends, it is useless to test too specific aspects of it.
Commits on Jun 14, 2012
  1. @claudep

    Fixed #12140 -- Fixed http.urlencode result for empty lists

    claudep authored
    Thanks aneil for the report and the initial patch.
  2. @claudep

    Fixed #17754 -- Refactored gis.measure

    claudep authored
    This refactoring does allow much easier MeasureBase subclassing.
    Many thanks to Ricardo di Virgilio for the initial patch.
  3. @claudep

    Discovered some geodjango tests with standard mechanism

    claudep authored
    No need to special case tests discovery for regular first-level
    gis tests.
  4. @claudep
  5. @spookylukey

    Reverted part of 169b1a4 which was mistakenly applied to a non-iterat…

    spookylukey authored
    …or class.
    
    Doing next(IfParser()) works for Python 2.7, because it calls
    IfParser.next(), but in Python 3 will call IfParser.__next__() which does
    not work since it is not an iterator and does not have that method.
  6. @spookylukey
Commits on Jun 15, 2012
  1. @claudep

    Favored text (StringIO) over binary content for deserialization

    claudep authored
    This is also more Python 3 compatible, as the json module in
    Python 3 is expecting text. Thanks Vinay Sajip for noticing it.
Commits on Jun 16, 2012
  1. @jphalip
  2. @jphalip

    Fixed #18477 -- Fixed colspan value when a TabularInline form contain…

    jphalip authored
    …s validation errors. Thanks to yedpodtrzitko for the report and patch.
  3. @jphalip
  4. @jphalip
Commits on Jun 17, 2012
  1. @jphalip

    Fixed #18420 -- Prevented the admin JS from crashing when the main fo…

    jphalip authored
    …rm contains no field. Thanks to maciej.maciaszek for the report and patch.
  2. @apollo13

    Fixed GIS testsuite.

    apollo13 authored
    Moved HAS_SPATIALREFSYS back into the tests namespace since it only operates
    on the default database and isn't a global flag like HAS_GDAL.
Commits on Jun 18, 2012
  1. @dhepper @apollo13

    Fixed #18450 -- Removed default values for i18n JavaScript URLs in Ad…

    dhepper authored apollo13 committed
    …min templates
  2. @dhepper @apollo13

    Fixed #18444 -- Replace hard coded "View on Site" URLs

    dhepper authored apollo13 committed
  3. @gabejackson @SmileyChris
  4. @SmileyChris

    Fixed #14502 again -- saner verbatim closing token

    SmileyChris authored
    Previously, the closing token for the verbatim tag was specified as the
    first argument of the opening token. As pointed out by Jannis, this is
    a rather major departure from the core tag standard.
    
    The new method reflects how you can give a specific closing name to
    {% block %} tags.
Commits on Jun 19, 2012
  1. @tsaylor @apollo13

    Fixed a documentation typo on the widget page.

    tsaylor authored apollo13 committed
  2. @dgerzo @apollo13

    Added support for gdal 1.9.

    dgerzo authored apollo13 committed
  3. @claudep

    Fixed #15271 -- Defined a to_python method for GeometryField

    claudep authored
    Thanks volrath and copelco for their work on the patch.
  4. @claudep

    Removed unneeded u prefixes

    claudep authored
Commits on Jun 22, 2012
  1. @spookylukey

    Fixed #17776 - DoesNotExist is not picklable

    spookylukey authored
    Thanks to ambv for the report
  2. @apollo13
  3. @apollo13
Commits on Jun 23, 2012
  1. @alex
  2. @jnns @apollo13

    Updated TEMPLATE_CONTEXT_PROCESSORS defaults in the docs.

    jnns authored apollo13 committed
    django.core.context_processors.tz was missing from default
    TEMPLATE_CONTEXT_PROCESSORS in the template api documentation.
  3. @bmihelac @apollo13

    Fixed url translation docs.

    bmihelac authored apollo13 committed
    ``include`` calls shouldn't have a $ sign at the end of the url pattern.
  4. @dmedvinsky @apollo13

    Fixed #18454 -- Added ability to pass a list of signals to `receiver`.

    dmedvinsky authored apollo13 committed
    Added ability to use receiver decorator in the following way:
    
        @receiver([post_save, post_delete], sender=MyModel)
        def signals_receiver(sender, **kwargs):
            ...
  5. @alex
  6. @alex
  7. @claudep
Commits on Jun 24, 2012
  1. @claudep

    Fixed #16317 -- Fixed dumpdata for self-referencing models and natura…

    claudep authored
    …l keys
    
    Thanks aldaran for the patch.
Commits on Jun 25, 2012
  1. @bradleyayers

    Add a test for #17914

    bradleyayers authored
  2. @bradleyayers
Commits on Jun 26, 2012
  1. @bradleyayers

    When reversing a view reference, choose the first occurrence in the U…

    bradleyayers authored
    …RLconf rather than the last.
  2. @bradleyayers
Something went wrong with that request. Please try again.