Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Ticket #18511: Error Message displays different for Changeforms and the Password Change screen. #180

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
Owner

timgraham commented Jul 27, 2013

merged in e07e403 - thanks!

@timgraham timgraham closed this Jul 27, 2013

Member

mjtamlyn commented Jul 29, 2013

This patch is kinda hard to read. Have any of the values in any particular template changed here? If so this would need to be mentioned as a backwardsly incompatible change - especially for international users who may be relying on the original values in their translation files.

Owner

timgraham commented Jul 29, 2013

No, there are no new strings.

As an aside, I thought issuing a release candidate and having a string freeze was the way handled that sort of thing.

Contributor

cobalys commented Jul 29, 2013

@mjtamlyn: Values (i.e. messages) have not changed.
This patch changes the position of the h1 titles in the templates under django/contrib/admin/templates/registration/ to make them look uniform with other templates in admin.
Also it merges the template variables for 'h1' and 'title' tag to display the same value.

Member

mjtamlyn commented Jul 29, 2013

Ok cool, that makes a lot of sense. Thanks!

@nanuxbe nanuxbe pushed a commit to nanuxbe/django that referenced this pull request Jul 2, 2016

@jezdez jezdez Improve heading for mailing list section. Fix #180. b03a650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment