Fixed #21363 - TimestampSigner.unsign accepts a timedelta #1835

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@bmispelon

View changes

docs/topics/signing.txt
@@ -121,10 +121,11 @@ created within a specified period of time::
'hello:1NMg5H:oPVuCqlJWmChm1rA2lyTUtelC-c'
>>> signer.unsign(value)
u'hello'
- >>> signer.unsign(value, max_age=10)
+ >>> import datetime

This comment has been minimized.

@bmispelon

bmispelon Oct 31, 2013

Member

To tidy things up a bit, you could move the import to the top of the example and also import timedelta directly.

@bmispelon

bmispelon Oct 31, 2013

Member

To tidy things up a bit, you could move the import to the top of the example and also import timedelta directly.

finally:
time.time = _time
+
+ def test_seconds(self):

This comment has been minimized.

@bmispelon

bmispelon Oct 31, 2013

Member

Adding a comment here about the deprecation will make it easier to come and remove the feature when the time comes.

@bmispelon

bmispelon Oct 31, 2013

Member

Adding a comment here about the deprecation will make it easier to come and remove the feature when the time comes.

Fixed #21363 - TimestampSigner.unsign accepts a timedelta
Using a number of seconds for `max_age` is deprecated.
@gavinwahl

This comment has been minimized.

Show comment
Hide comment
@gavinwahl

gavinwahl Oct 31, 2013

Contributor

Thanks for the review, I fixed those issues.

Contributor

gavinwahl commented Oct 31, 2013

Thanks for the review, I fixed those issues.

@timgraham

This comment has been minimized.

Show comment
Hide comment
@timgraham

timgraham Nov 8, 2013

Member

Per the discussion in the ticket, this has been rejected in its current form.

Member

timgraham commented Nov 8, 2013

Per the discussion in the ticket, this has been rejected in its current form.

@timgraham timgraham closed this Nov 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment