New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #21446 – Allowed not performing redirect in set_language view. #1923

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@KrzysiekJ
Contributor

KrzysiekJ commented Nov 15, 2013

Fixed #21446 – Made set_language return 204 status code for AJAX requ…
…ests.

The redirect is still performed if the “next” parameter is present.
@@ -372,6 +372,9 @@ Internationalization
in the corresponding entry in the PO file, which makes the translation
process easier.
* :func:`django.views.i18n.set_language` now returns 204 status code for AJAX

This comment has been minimized.

@timgraham

timgraham Jun 5, 2014

Member

needs to be 1.8 now

@timgraham

timgraham Jun 5, 2014

Member

needs to be 1.8 now

* For AJAX requests, the fallback will be performed only if the ``next`` parameter
was set. Otherwise a 204 status code will be returned.
* For non-AJAX requests, the fallback will be performed always.

This comment has been minimized.

@timgraham

timgraham Jun 5, 2014

Member

Need a .. versionchanged:: 1.8 with a description of changes.

@timgraham

timgraham Jun 5, 2014

Member

Need a .. versionchanged:: 1.8 with a description of changes.

``POST`` or ``GET`` data. If that is found and Django considers it to be a safe
URL (i.e. it doesn’t point to a different host and uses a safe scheme), a
redirect to that URL will be performed. Otherwise, Django may fall back to
redirecting the user to the URL

This comment has been minimized.

@timgraham

timgraham Jun 5, 2014

Member

odd line break

@timgraham

timgraham Jun 5, 2014

Member

odd line break

@timgraham

This comment has been minimized.

Show comment
Hide comment
@timgraham

timgraham Oct 31, 2014

Member

Closing in absence of follow-up, please send a new PR if you can update it, thanks!

Member

timgraham commented Oct 31, 2014

Closing in absence of follow-up, please send a new PR if you can update it, thanks!

@timgraham timgraham closed this Oct 31, 2014

@claudep

This comment has been minimized.

Show comment
Hide comment
@claudep

claudep Mar 28, 2016

Member

Updated pull request: #6351

Member

claudep commented Mar 28, 2016

Updated pull request: #6351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment