Fixed #36446 -- Restored "q" in internal MediaType.params property. #19548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Contributor
Author
|
@andersk @RealOrangeOne what do you think about this solution? |
RealOrangeOne
approved these changes
Jun 9, 2025
The "q" key was removed while addressing ticket #36411. Despite `MediaType.params` is undocumented and considered internal, it was used in third-party projects (Zulip reported breakage), so this work restored the `q` key in `params`. Thanks Anders Kaseorg for the report. Regression in c075508.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite undocumented and internal, the "q" key was removed from the MediaType.params while fixing Refs #36411.
Thanks Anders Kaseorg for the report.
Regression in c075508.
Trac ticket number
ticket-36446
Branch description
Restore original
paramsand add a newrange_paramsfollowing this previous PR conversation.I chose a slightly different name for the new property: range_params. I think this name matches better the spec, and also "MediaType.type_params" felt a bit redundant.