Fixed #17713 -- Renamed allows_primary_key_0 to allows_auto_pk_0. #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MySQL does allow primary key with value 0. It only forbids autoincrement primary key with value 0.
|
@akaariai Do you feel we need to provide documentation in the release notes for this change? |
|
I would say it's not that important, Database features are not documented, and should probably be considered a relatively internal API. That said, a oneline in Backwards incompat changes wouldn't do any harm. |
|
merged in d3cf6cf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL does allow primary key with value 0. It only forbids autoincrement
primary key with value 0.