Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Improved #21230 -- removed direct settings manipulation from template tests #2003

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

unaizalakain commented Nov 28, 2013

No description provided.

@bmispelon bmispelon commented on the diff Nov 28, 2013

tests/template_tests/tests.py
expected_invalid_str = 'INVALID'
- # Set ALLOWED_INCLUDE_ROOTS so that ssi works.
@bmispelon

bmispelon Nov 28, 2013

Member

This comment should probably be kept as well.

Owner

timgraham commented Nov 29, 2013

For the commit message, rather than "Improved ... ":

'If your commit references a ticket in the Django ticket tracker but does not close the ticket, include the phrase “Refs #xxxxx”, where “xxxxx” is the number of the ticket your commit references. This will automatically post a comment to the appropriate ticket.'

Contributor

unaizalakain commented Nov 29, 2013

Thanks for your reviews!

Owner

timgraham commented Nov 30, 2013

merged in 2688462 (fixed a flake8 indentation error).

@timgraham timgraham closed this Nov 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment