Skip to content

Ticket #18616: contrib.auth signal user_login_fail #201

Closed
wants to merge 12 commits into from

4 participants

@micolous

https://code.djangoproject.com/ticket/18616

Note: it seems I made a typo on the branch name, it is ticket_18686 instead of ticket_18616.

@brad

I personally think user_login_failed would be a better name for this signal, to better match the verb form of the other two.

You raise a good point Brad, I'll update this pull request with another commit changing to this.

@micolous micolous per a suggestion by Brad Pitcher, I have changed the signal name to "…
…user_login_failed" to match the verb tense of the other signals emitted by contrib.auth.
3918f25
@apollo13
Django member

@brad, @micolous Please incorporate the Doc PR into this PR.

@brad
brad commented Jul 17, 2012

I'll send a pull request your way, @micolous

@brad
brad commented Jul 17, 2012

GitHub won't let me send you a pull request, even when I branch directly from you. If you like you could pull my ticket_18616_docs branch to get the docs. I made updated to the sender documentation.

@micolous

Done.

@brad
brad commented Jul 18, 2012

Sorry, looks like I forgot to get that sender doc change in that branch. I have made the change now if you want to pull again.

@jezdez
Django member
jezdez commented Jul 21, 2012

Remember folks to always mention in the ticket which pull request is the correct one!

@brad
brad commented Jul 21, 2012

Sorry, my mistake.

@micolous

Merged Brad's documentation fixes.

@brad
brad commented Sep 8, 2012

This patch no longer applies cleanly to master. Can you fix it, or pull from https://github.com/brad/django/tree/ticket_18616. We are in the middle of a sprint so we may manage to get it merged in today.

@apollo13
Django member
apollo13 commented Jan 1, 2013

This was fixed in 7cc4068

@apollo13 apollo13 closed this Jan 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.