Note: it seems I made a typo on the branch name, it is ticket_18686 instead of ticket_18616.
Ticket #18686: contrib.auth signal user_login_fail
Implemented unit tests for login_fail signal
Merge remote-tracking branch 'micolous/ticket_18686' into micolous
I personally think user_login_failed would be a better name for this signal, to better match the verb form of the other two.
You raise a good point Brad, I'll update this pull request with another commit changing to this.
per a suggestion by Brad Pitcher, I have changed the signal name to "…
…user_login_failed" to match the verb tense of the other signals emitted by contrib.auth.
@brad, @micolous Please incorporate the Doc PR into this PR.
I'll send a pull request your way, @micolous
Merge branch 'ticket_18686' of git://github.com/micolous/django into …
documentation for the new user_login_failed signal
GitHub won't let me send you a pull request, even when I branch directly from you. If you like you could pull my ticket_18616_docs branch to get the docs. I made updated to the sender documentation.
fix copy/pasted sender doc
Sorry, looks like I forgot to get that sender doc change in that branch. I have made the change now if you want to pull again.
Remember folks to always mention in the ticket which pull request is the correct one!
Sorry, my mistake.
Merge remote-tracking branch 'brad/ticket_18616_docs' into ticket_18686
Merged Brad's documentation fixes.
fix docs merge conflict
This patch no longer applies cleanly to master. Can you fix it, or pull from https://github.com/brad/django/tree/ticket_18616. We are in the middle of a sprint so we may manage to get it merged in today.
Merge branch 'ticket_18616' of git://github.com/brad/django into tick…
Merge branch 'django/master' into ticket_18686
Merge branch 'master' into ticket_18686
This was fixed in 7cc4068