Ticket #18619: get_inline_instances() should accept an instance parameter #202

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants
@sjaensch

This is consistent with the other ModelAdmin methods. Please refer to https://code.djangoproject.com/ticket/18619 for further information.

@domguard

This comment has been minimized.

Show comment
Hide comment
@domguard

domguard Jul 13, 2012

Yes, taking permissions in account was missing in my patch
You just miss another mention of the paramter at line 934, see my comment here : https://code.djangoproject.com/ticket/17856#comment:10

Yes, taking permissions in account was missing in my patch
You just miss another mention of the paramter at line 934, see my comment here : https://code.djangoproject.com/ticket/17856#comment:10

@sjaensch

This comment has been minimized.

Show comment
Hide comment
@sjaensch

sjaensch Jul 13, 2012

Thanks, setting it explicitly is indeed better than relying on the default value.

Thanks, setting it explicitly is indeed better than relying on the default value.

domguard and others added some commits Aug 3, 2012

@aaugustin

This comment has been minimized.

Show comment
Hide comment
@aaugustin

aaugustin Oct 20, 2012

Member

Merged in c2e19e2.

Member

aaugustin commented Oct 20, 2012

Merged in c2e19e2.

@aaugustin aaugustin closed this Oct 20, 2012

nanuxbe pushed a commit to nanuxbe/django that referenced this pull request Jul 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment