Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed #4282 -- startproject should honor umask #2061

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

schmitch commented Dec 10, 2013

Currently I updated the old patch that it works under python2 and python3.
Also I added a test suite that checks if a file has a mode of 0600 and a directory has a mode of 0700 if i set the umask to 0o077

Fixed #4282 -- startproject should honor umask
I updated the old patch that it works under python2 and python3.
Also I added a test suite that checks if a file has a mode of 0600 and a directory has a mode of 0700 if i set the umask to 0o077
Updated the pull requests after a quick review from apollo13
Contributor

schmitch commented Dec 22, 2013

updated the pull request.

Member

claudep commented Jun 14, 2014

The original motivation for adding shutil.copymode was manage.py loosing its executable bit. Instead of this umask dance, couldn't we just check if old_path is executable (os.access(old_path, os.X_OK)) and then call a new make_executable method on the model of make_writeable?

Owner

timgraham commented Sep 10, 2014

Closing due to lack of follow-up.

@timgraham timgraham closed this Sep 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment