Switched setup.py to setuptools. #2116

Merged
merged 3 commits into from Jan 19, 2014

Conversation

Projects
None yet
5 participants
@apollo13
Member

apollo13 commented Dec 26, 2013

This should allow windows users to easily invoke django-admin without (in the worst case) having to type:
c:\python\python.exe c:\python\scripts\django-admin.py startproject

@timgraham

This comment has been minimized.

Show comment
Hide comment
@timgraham

timgraham Dec 26, 2013

Member

Do we need zip_safe=False ala #13587?

Member

timgraham commented Dec 26, 2013

Do we need zip_safe=False ala #13587?

@apollo13

This comment has been minimized.

Show comment
Hide comment
@apollo13

apollo13 Dec 26, 2013

Member

python setup.py sdist 2>&1|grep "module references __file__" shows no warning, when is that output generated normally? I think zip_safe did also prevent .eggs which is a good thing, so we might wanna add it again? /cc @dstufft

Member

apollo13 commented Dec 26, 2013

python setup.py sdist 2>&1|grep "module references __file__" shows no warning, when is that output generated normally? I think zip_safe did also prevent .eggs which is a good thing, so we might wanna add it again? /cc @dstufft

@timgraham

This comment has been minimized.

Show comment
Hide comment
@timgraham

timgraham Dec 26, 2013

Member

The warning is output when running setup.py install. As you mentioned, my understanding is this will prevent from installing as an egg which causes problem for loading templates.

Member

timgraham commented Dec 26, 2013

The warning is output when running setup.py install. As you mentioned, my understanding is this will prevent from installing as an egg which causes problem for loading templates.

@apollo13

This comment has been minimized.

Show comment
Hide comment
@apollo13

apollo13 Dec 26, 2013

Member

I don't get the warning, but I did set zip_safe=False again.

Member

apollo13 commented Dec 26, 2013

I don't get the warning, but I did set zip_safe=False again.

aaugustin added a commit that referenced this pull request Jan 19, 2014

Merge pull request #2116 from apollo13/setuptools
 Switched setup.py to setuptools.

@aaugustin aaugustin merged commit 66f546b into django:master Jan 19, 2014

@remram44

This comment has been minimized.

Show comment
Hide comment
@remram44

remram44 Jan 19, 2014

This changes the "django-admin.py" command to "django-admin"... it means a lot of documentation needs to be updated.

This changes the "django-admin.py" command to "django-admin"... it means a lot of documentation needs to be updated.

@apollo13

This comment has been minimized.

Show comment
Hide comment

@dangra dangra referenced this pull request in scrapy/scrapy Aug 1, 2014

Merged

[WIP] Modernize setup.py #836

1 of 1 task complete
@getcwd

This comment has been minimized.

Show comment
Hide comment
@getcwd

getcwd Oct 23, 2014

Would you care to update the documents to state that now Django 1.7 depends on setuptools which doesn't come with Python versions that are less than 3.4?

At least docs/topics/install.txt and docs/intro/install.txt should be updated. There may be other places like docs/howto/windows.txt also need update too.

getcwd commented on 929cead Oct 23, 2014

Would you care to update the documents to state that now Django 1.7 depends on setuptools which doesn't come with Python versions that are less than 3.4?

At least docs/topics/install.txt and docs/intro/install.txt should be updated. There may be other places like docs/howto/windows.txt also need update too.

This comment has been minimized.

Show comment
Hide comment
@apollo13

apollo13 Oct 25, 2014

Member

@getcwd I don't think that's necessary, pip requires setuptools and is the suggested installation method. As for windows: I don't use it, so no idea what is needed there (but pip works there too)

Member

apollo13 replied Oct 25, 2014

@getcwd I don't think that's necessary, pip requires setuptools and is the suggested installation method. As for windows: I don't use it, so no idea what is needed there (but pip works there too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment