Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed #21829 -- Added default AppConfigs. #2210

Merged
merged 1 commit into from Jan 25, 2014

Conversation

Projects
None yet
2 participants
Owner

aaugustin commented Jan 24, 2014

Thanks Russell for the report, Carl for the design, Marc for the initial
patch, and everyone who contributed to the design discussion.

Owner

carljm commented Jan 25, 2014

One comment on the commit message - I believe it was @freakboy3742 who suggested the default_app_config approach as one possible solution to the "we can't rely on AppConfig" problem. So I'm not sure it's fair to credit me with the design here, though I did endorse that approach and suggest some tweaks.

I mentioned that I would look over the docs, and I did. It seems you or Marc already fixed most of the issues I'd remembered from my last review. I made two new docs commits at https://github.com/carljm/django/compare/default-app-config which you can look over and pull in here if they make sense to you - I didn't make a new pull request. Otherwise, this looks ready to me.

@aaugustin aaugustin Fixed #21829 -- Added default AppConfigs.
Thanks Russell for the report, Marc for the initial patch, Carl for the
final review, and everyone who contributed to the design discussion.
2ff93e0

@aaugustin aaugustin merged commit 2ff93e0 into django:master Jan 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment