Move Test settings into an inner dictionary in database settings #2400

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
@shaib
Member

shaib commented Mar 5, 2014

This pull request is in fact two:
The first two commits move the test settings into their own dictionary.
The third renames the "CREATE" and "USER_CREATE" settings to "CREATE_DB" and "CREATE_USER". This is important, because I want to make "CREATE_DB" available to all backends -- and because renaming settings after this change is going to be much harder.

django/db/backends/oracle/creation.py
- except KeyError:
- pass
- return name
+ return self._test_settings_get('PASSWD', default=PASSWORD)

This comment has been minimized.

Show comment Hide comment
@jarshwah

jarshwah Mar 5, 2014

Member

Since this setting is now in a sub-dictionary and elides the TEST_ prefix, should the key be named PASSWORD rather than PASSWD to be more consistent with the non-test settings?

@jarshwah

jarshwah Mar 5, 2014

Member

Since this setting is now in a sub-dictionary and elides the TEST_ prefix, should the key be named PASSWORD rather than PASSWD to be more consistent with the non-test settings?

This comment has been minimized.

Show comment Hide comment
@shaib

shaib Mar 5, 2014

Member

Good catch. Thanks.

@shaib

shaib Mar 5, 2014

Member

Good catch. Thanks.

@jarshwah

This comment has been minimized.

Show comment Hide comment
@jarshwah

jarshwah Mar 5, 2014

Member

This patch stemmed from the discussion on https://code.djangoproject.com/ticket/21775 , but the settings for datafile and tablespace size are not implemented. Should these settings be added in a separate PR, or does it make sense to add them now with existing defaults? Otherwise, to test on certain oracle installations, you're required to prebuild the test database and not dynamically create it.

Member

jarshwah commented Mar 5, 2014

This patch stemmed from the discussion on https://code.djangoproject.com/ticket/21775 , but the settings for datafile and tablespace size are not implemented. Should these settings be added in a separate PR, or does it make sense to add them now with existing defaults? Otherwise, to test on certain oracle installations, you're required to prebuild the test database and not dynamically create it.

@shaib

This comment has been minimized.

Show comment Hide comment
@shaib

shaib Mar 9, 2014

Member

Committed manually.

Member

shaib commented Mar 9, 2014

Committed manually.

@shaib shaib closed this Mar 9, 2014

@shaib shaib deleted the shaib:test-settings branch Mar 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment