New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #22220, improved reverse() documention #2544

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@bendavis78
Contributor

bendavis78 commented Apr 14, 2014

No description provided.

@charettes

View changes

docs/ref/urlresolvers.txt Outdated
from django.core.urlresolvers import reverse
def myview(request):
return HttpResponseRedirect(reverse('arch-summary', args=[1945]))
You can also pass ``kargs`` instead of ``args``. For example::

This comment has been minimized.

@charettes
@bendavis78

This comment has been minimized.

Contributor

bendavis78 commented Apr 15, 2014

Ah, nice catch. Fixed.

@ubernostrum

This comment has been minimized.

Member

ubernostrum commented Apr 15, 2014

Could you rebase this into a single commit for sake of cleaner history when it merges?

@timgraham

View changes

docs/ref/urlresolvers.txt Outdated
:ref:`URL pattern name <naming-url-patterns>`. Normally, you won't need to
worry about the ``urlconf`` parameter and will only pass in the positional and
keyword arguments to use in the URL matching. For example::
``viewname`` can be a string containing the python path to the view object, a

This comment has been minimized.

@timgraham

timgraham Apr 15, 2014

Member

python -> Python (or PYTHONPATH)?

@timgraham

View changes

docs/ref/urlresolvers.txt Outdated
url(r'^archive/$', 'news.views.archive', name='news_archive')
you can use any of the following to resolve the url::

This comment has been minimized.

@timgraham

timgraham Apr 15, 2014

Member

url -> URL

@bendavis78

This comment has been minimized.

Contributor

bendavis78 commented Apr 16, 2014

Changed "python path" -> "Python path" and "url -> URL". Rebased into single commit.

worry about the ``urlconf`` parameter and will only pass in the positional and
keyword arguments to use in the URL matching. For example::
``viewname`` can be a string containing the Python path to the view object, a
`URL pattern name`_, or the callable view object. For example, given the

This comment has been minimized.

@timgraham

timgraham Apr 16, 2014

Member

I'll merge this, but this appears to be a broken link? should I change it back?

@timgraham

This comment has been minimized.

Member

timgraham commented Apr 17, 2014

Fixed link and merged in 030dd4f.

@timgraham timgraham closed this Apr 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment