Fixed #21587 -- deprecation warning for upcoming permanent default #2564

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@arachnegl
Contributor

arachnegl commented Apr 15, 2014

No description provided.

@Gwildor

This comment has been minimized.

Show comment Hide comment
@Gwildor

Gwildor Apr 15, 2014

I have the same concern on this change as on #2432: "...because what if the user has set the flag as an attribute on the view instead of passing it along when initializing the view?"

Perhaps checking both kwargs and using hasattr is the way to go.

Gwildor commented Apr 15, 2014

I have the same concern on this change as on #2432: "...because what if the user has set the flag as an attribute on the view instead of passing it along when initializing the view?"

Perhaps checking both kwargs and using hasattr is the way to go.

@timgraham

This comment has been minimized.

Show comment Hide comment
@timgraham

timgraham May 16, 2014

Member

Closing this as it needs further work as noted above and in the ticket.

Member

timgraham commented May 16, 2014

Closing this as it needs further work as noted above and in the ticket.

@timgraham timgraham closed this May 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment