For ticket 22463.
I haven't yet analyzed the inconsistencies between final newlines in the JSON files.
Some more potential changes that could be made:
You can confirm that this commit is purely a whitespace change (except for the addition of the .editorconfig file) by running git diff -w or using ?w=1 on Github.
Check http://editorconfig.org for more details on EditorConfig.
Add newlines to the ends of files missing them
- Ensure all CSS files have a final newline
- Ensure all HTML files have a final newline
Remove tab indentation (use spaces)
Add EditorConfig file declaring current code style
Add a basic JSHint configuration file for JS code
Install jshint with:
npm install -g jshint
Check code with:
I'd simply ignore the .graffle files as they are machine-generated.
In the .graffle files will never be edited manually, I would just remove their reference from EditorConfig and treat them as if they were a binary file (note that .png and many other file types are not listed because they are binary).
Yes, that's what I meant. We are in agreement.
Ignore minified and library files in jshint
I merged the newline/tab fixes. Are you still working on this? I think we should add documentation about the lint configs before we merge it.
@timgraham #3003 fixes most of the JS configuration so jshint works as expected. I made a branch that finishes the JS linting started by that pull request but I have not made a pull request for it: https://github.com/treyhunner/django/tree/fix-jshint-errors
Okay, well I guess this PR (the editor config) cannot be merged as it is, so closing for now.