Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator comparisons #2637

Merged

Conversation

davidszotten
Copy link
Contributor

[1.7.x] Fixed #22588 -- Fix RegexValidator __eq__
Compare parameters instead of re.pattern instances, and add the other
parameters to the comparison. Also add a __ne__ to make assertNotEqual
work properly.

@timgraham
Copy link
Member

Should we compare the regex's flags as well?

Also please note our commit message guidelines (should start with "Fixed #XXXXX --" and commit message in past tense). Thanks!

@davidszotten
Copy link
Contributor Author

ah, definitely. and probably inverse_match as well

apologies for commit message and not reading the guidelines properly. figured EAFP :)

is the preference for me to squash all commits on the pr, or to leave multiple commits for review and for you guys to squash on merge?

@timgraham
Copy link
Member

For larger patches, separate commits would make reviewing changes easier, but this is small enough I think you can squash commits.

Compare parameters instead of re.pattern instances, and add the other
parameters to the comparison. Also add a __ne__ to make assertNotEqual
work properly.
andrewgodwin added a commit that referenced this pull request May 9, 2014
[1.7.x] Fixed #22588 -- Fix RegexValidator __eq__
@andrewgodwin andrewgodwin merged commit d2e96b5 into django:stable/1.7.x May 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants