Skip to content

[py3] Fixed EmailMessage default encoding. #272

Closed
wants to merge 1 commit into from

4 participants

@dmishe
dmishe commented Aug 16, 2012

Basically the plumbing under EmailMessage needs to know about its encoding, for some reason the only place where encoding is defaulted to DEFAULT_CHARSET is message. I moved it to class init.

@apollo13
Django member
apollo13 commented Jan 1, 2013

@dmishe Can you please open a ticket and add tests?

@dmishe
dmishe commented Jan 26, 2013

This is from py3 sprint times, I am not even sure it's still relevant, I'll check

@aaugustin
Django member

This could be a good idea, but I don't understand what you're trying to achieve exactly: making EmailMessage more easily customizable via subclassing?

@dmishe
dmishe commented Feb 1, 2013

At the time of py3 sprint, this was a breaking bug, because IIRC EmailMessage didn't know about it's encoding and tried to use ascii, because encoding wasn't passed down to it

@timgraham
Django member

Is there a trac ticket?

@dmishe
dmishe commented May 31, 2013

No, it's old and was a part of py3 sprint, I don't think it's relevant anymore.

@dmishe dmishe closed this May 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.