[py3] fixed __proxy__.decode doesn't exists #281

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@Natim
Contributor

Natim commented Aug 17, 2012

fixed proxy.decode doesn't exists on django/contrib/auth/decorators.py

@aaugustin aaugustin closed this Aug 17, 2012

@aaugustin

This comment has been minimized.

Show comment
Hide comment
@aaugustin

aaugustin Aug 17, 2012

Member

GitHub seems to have lost my comment :( Here is it again.

I'd prefer to fix the root cause rather than this specific symptom, as explained in this ticket:
https://code.djangoproject.com/ticket/18776
The conditional on six.PY3 is needlessly complex, six.text_type just does the job.

If we chose this path, in fact, we'd probably just slap force_text around login_url.

Member

aaugustin commented Aug 17, 2012

GitHub seems to have lost my comment :( Here is it again.

I'd prefer to fix the root cause rather than this specific symptom, as explained in this ticket:
https://code.djangoproject.com/ticket/18776
The conditional on six.PY3 is needlessly complex, six.text_type just does the job.

If we chose this path, in fact, we'd probably just slap force_text around login_url.

@Natim

This comment has been minimized.

Show comment
Hide comment
@Natim

Natim Aug 17, 2012

Contributor

Yes

Contributor

Natim commented Aug 17, 2012

Yes

nanuxbe pushed a commit to nanuxbe/django that referenced this pull request Jul 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment