Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Bigint AutoField (fixes #56, #13774) #308

Closed
wants to merge 14 commits into from

9 participants

@pzinovkin

Alternative approach to fix ticket 56.
Based on discussion #49
This approach doesn't change AutoField behavior. Only those who need extended int range may use it.
It keeps values ranges consistent between databases. Also it works nice with related fields.
Now with tests.

claudep added some commits
@claudep claudep Fixed #12460 -- Improved inspectdb handling of special field names
Thanks mihail lukin for the report and elijahr and kgibula for their
work on the patch.
395c608
@claudep claudep Fixed #18843 -- Replaced more special chars in column names (inspectdb)
Thanks airstrike for the report.
f5ea730
@caltrain

Shouldn't it be
if new_name.find('') >0:

instead of
if new_name.find('
') >= 0: ?
same goes for the following conditions. Please correct me if I am wrong. Thanks!

Collaborator

@mageshkhanna

From help(str.find) output: S.find(sub [,start [,end]]) -> int -- Return the lowest index in S where substring sub is found [...] Return -1 on failure.

So, the code is correct as it is.

ramiro and others added some commits
@ramiro ramiro Modified docs about SpatiaLite version that doesn't need manual initi…
…al SQL file loading as per 675431d.
6786b38
@kmtracey kmtracey Merge pull request #301 from carlospalol/quickfix/blog-post-typo
Fixed typo in docs
14924ea
@timgraham timgraham Fixed #18847 - Updated for media examples to use static.example.com. …
…Thanks Jamie Curle.
e57338f
@alex alex Cleaned up the implementation of in_bulk b7c3b04
@claudep claudep Added a GeoDjango test with a raw query (Refs #17448)
Thanks David Eklund for the initial patch.
d7a2e81
@akaariai akaariai Fixed #16715 -- Fixed join promotion logic for nested nullable FKs
The joins for nested nullable foreign keys were often created as INNER
when they should have been OUTER joins. The reason was that only the
first join in the chain was promoted correctly. There were also issues
with select_related etc.

The basic structure for this problem was:
  A -[nullable]-> B -[nonnull]-> C

And the basic problem was that the A->B join was correctly LOUTER,
the B->C join not.

The major change taken in this patch is that now if we promote a join
A->B, we will automatically promote joins B->X for all X in the query.
Also, we now make sure there aren't ever join chains like:
   a LOUTER b INNER c
If the a -> b needs to be LOUTER, then the INNER at the end of the
chain will cancel the LOUTER join and we have a broken query.

Sebastian reported this problem and did also major portions of the
patch.
01b9c3d
@timgraham timgraham Fixed #18804 - Reorganized class based views docs a bit; thanks antho…
…nyb for the initial patch.
df7c1a1
@timgraham timgraham Updated doc for settings.MEDIA_ROOT based on what's generated by sett…
…ings.py; thanks ryan-blunden.
e6e01f6
@claudep claudep Fixed #17448 -- Improved test and documented raw-sql gis query 62e1c5a
@aaugustin aaugustin Fixed #18852 -- Restored backwards compatibility
in django.core.signing. Specifically, kept the same return types
(str/unicode) under Python 2. Related to [92b2dec].
28ea4d4
@ramiro ramiro Fixed typo in model fields reference docs. c73f2bd
@pzinovkin pzinovkin Bigint AutoField
Fixes #56, #13774
6ea46a2
@timgraham
Owner

This PR needs to be reworked so it doesn't include unrelated commits (caused by when someone accidentally force pushed to (django/django)).

@timgraham timgraham closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 23, 2012
  1. @claudep

    Fixed #12460 -- Improved inspectdb handling of special field names

    claudep authored
    Thanks mihail lukin for the report and elijahr and kgibula for their
    work on the patch.
  2. @claudep

    Fixed #18843 -- Replaced more special chars in column names (inspectdb)

    claudep authored
    Thanks airstrike for the report.
Commits on Aug 24, 2012
  1. @ramiro
  2. @kmtracey
  3. @timgraham
  4. @alex

    Cleaned up the implementation of in_bulk

    alex authored Alex Gaynor committed
Commits on Aug 25, 2012
  1. @claudep

    Added a GeoDjango test with a raw query (Refs #17448)

    claudep authored
    Thanks David Eklund for the initial patch.
  2. @akaariai

    Fixed #16715 -- Fixed join promotion logic for nested nullable FKs

    akaariai authored
    The joins for nested nullable foreign keys were often created as INNER
    when they should have been OUTER joins. The reason was that only the
    first join in the chain was promoted correctly. There were also issues
    with select_related etc.
    
    The basic structure for this problem was:
      A -[nullable]-> B -[nonnull]-> C
    
    And the basic problem was that the A->B join was correctly LOUTER,
    the B->C join not.
    
    The major change taken in this patch is that now if we promote a join
    A->B, we will automatically promote joins B->X for all X in the query.
    Also, we now make sure there aren't ever join chains like:
       a LOUTER b INNER c
    If the a -> b needs to be LOUTER, then the INNER at the end of the
    chain will cancel the LOUTER join and we have a broken query.
    
    Sebastian reported this problem and did also major portions of the
    patch.
  3. @timgraham

    Fixed #18804 - Reorganized class based views docs a bit; thanks antho…

    timgraham authored
    …nyb for the initial patch.
  4. @timgraham

    Updated doc for settings.MEDIA_ROOT based on what's generated by sett…

    timgraham authored
    …ings.py; thanks ryan-blunden.
  5. @claudep
  6. @aaugustin

    Fixed #18852 -- Restored backwards compatibility

    aaugustin authored
    in django.core.signing. Specifically, kept the same return types
    (str/unicode) under Python 2. Related to [92b2dec].
Commits on Aug 26, 2012
  1. @ramiro
  2. @pzinovkin

    Bigint AutoField

    pzinovkin authored
    Fixes #56, #13774
Something went wrong with that request. Please try again.