Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Bigint AutoField (fixes #56, #13774) #308

Closed
wants to merge 14 commits into from

9 participants

Pavel Zinovkin Tim Graham Ramiro Morales Magesh Vadivelu Claude Paroz Karen Tracey Alex Gaynor Anssi Kääriäinen Aymeric Augustin
Pavel Zinovkin

Alternative approach to fix ticket 56.
Based on discussion #49
This approach doesn't change AutoField behavior. Only those who need extended int range may use it.
It keeps values ranges consistent between databases. Also it works nice with related fields.
Now with tests.

added some commits August 23, 2012
Claude Paroz Fixed #12460 -- Improved inspectdb handling of special field names
Thanks mihail lukin for the report and elijahr and kgibula for their
work on the patch.
395c608
Claude Paroz Fixed #18843 -- Replaced more special chars in column names (inspectdb)
Thanks airstrike for the report.
f5ea730
Magesh Vadivelu

Shouldn't it be
if new_name.find('') >0:

instead of
if new_name.find('
') >= 0: ?
same goes for the following conditions. Please correct me if I am wrong. Thanks!

Owner

@mageshkhanna

From help(str.find) output: S.find(sub [,start [,end]]) -> int -- Return the lowest index in S where substring sub is found [...] Return -1 on failure.

So, the code is correct as it is.

and others added some commits August 23, 2012
Ramiro Morales Modified docs about SpatiaLite version that doesn't need manual initi…
…al SQL file loading as per 675431d.
6786b38
Karen Tracey Merge pull request #301 from carlospalol/quickfix/blog-post-typo
Fixed typo in docs
14924ea
Tim Graham Fixed #18847 - Updated for media examples to use static.example.com. …
…Thanks Jamie Curle.
e57338f
Alex Gaynor Cleaned up the implementation of in_bulk b7c3b04
Claude Paroz Added a GeoDjango test with a raw query (Refs #17448)
Thanks David Eklund for the initial patch.
d7a2e81
Anssi Kääriäinen Fixed #16715 -- Fixed join promotion logic for nested nullable FKs
The joins for nested nullable foreign keys were often created as INNER
when they should have been OUTER joins. The reason was that only the
first join in the chain was promoted correctly. There were also issues
with select_related etc.

The basic structure for this problem was:
  A -[nullable]-> B -[nonnull]-> C

And the basic problem was that the A->B join was correctly LOUTER,
the B->C join not.

The major change taken in this patch is that now if we promote a join
A->B, we will automatically promote joins B->X for all X in the query.
Also, we now make sure there aren't ever join chains like:
   a LOUTER b INNER c
If the a -> b needs to be LOUTER, then the INNER at the end of the
chain will cancel the LOUTER join and we have a broken query.

Sebastian reported this problem and did also major portions of the
patch.
01b9c3d
Tim Graham Fixed #18804 - Reorganized class based views docs a bit; thanks antho…
…nyb for the initial patch.
df7c1a1
Tim Graham Updated doc for settings.MEDIA_ROOT based on what's generated by sett…
…ings.py; thanks ryan-blunden.
e6e01f6
Claude Paroz Fixed #17448 -- Improved test and documented raw-sql gis query 62e1c5a
Aymeric Augustin Fixed #18852 -- Restored backwards compatibility
in django.core.signing. Specifically, kept the same return types
(str/unicode) under Python 2. Related to [92b2dec].
28ea4d4
Ramiro Morales Fixed typo in model fields reference docs. c73f2bd
Pavel Zinovkin Bigint AutoField
Fixes #56, #13774
6ea46a2
Tim Graham
Owner

This PR needs to be reworked so it doesn't include unrelated commits (caused by when someone accidentally force pushed to (django/django)).

Tim Graham timgraham closed this February 07, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 14 unique commits by 9 authors.

Aug 23, 2012
Claude Paroz Fixed #12460 -- Improved inspectdb handling of special field names
Thanks mihail lukin for the report and elijahr and kgibula for their
work on the patch.
395c608
Claude Paroz Fixed #18843 -- Replaced more special chars in column names (inspectdb)
Thanks airstrike for the report.
f5ea730
Ramiro Morales Modified docs about SpatiaLite version that doesn't need manual initi…
…al SQL file loading as per 675431d.
6786b38
Aug 24, 2012
Karen Tracey Merge pull request #301 from carlospalol/quickfix/blog-post-typo
Fixed typo in docs
14924ea
Tim Graham Fixed #18847 - Updated for media examples to use static.example.com. …
…Thanks Jamie Curle.
e57338f
Alex Gaynor Cleaned up the implementation of in_bulk b7c3b04
Aug 25, 2012
Claude Paroz Added a GeoDjango test with a raw query (Refs #17448)
Thanks David Eklund for the initial patch.
d7a2e81
Anssi Kääriäinen Fixed #16715 -- Fixed join promotion logic for nested nullable FKs
The joins for nested nullable foreign keys were often created as INNER
when they should have been OUTER joins. The reason was that only the
first join in the chain was promoted correctly. There were also issues
with select_related etc.

The basic structure for this problem was:
  A -[nullable]-> B -[nonnull]-> C

And the basic problem was that the A->B join was correctly LOUTER,
the B->C join not.

The major change taken in this patch is that now if we promote a join
A->B, we will automatically promote joins B->X for all X in the query.
Also, we now make sure there aren't ever join chains like:
   a LOUTER b INNER c
If the a -> b needs to be LOUTER, then the INNER at the end of the
chain will cancel the LOUTER join and we have a broken query.

Sebastian reported this problem and did also major portions of the
patch.
01b9c3d
Tim Graham Fixed #18804 - Reorganized class based views docs a bit; thanks antho…
…nyb for the initial patch.
df7c1a1
Tim Graham Updated doc for settings.MEDIA_ROOT based on what's generated by sett…
…ings.py; thanks ryan-blunden.
e6e01f6
Claude Paroz Fixed #17448 -- Improved test and documented raw-sql gis query 62e1c5a
Aymeric Augustin Fixed #18852 -- Restored backwards compatibility
in django.core.signing. Specifically, kept the same return types
(str/unicode) under Python 2. Related to [92b2dec].
28ea4d4
Aug 26, 2012
Ramiro Morales Fixed typo in model fields reference docs. c73f2bd
Pavel Zinovkin Bigint AutoField
Fixes #56, #13774
6ea46a2
Something went wrong with that request. Please try again.