Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #23302 -- Added --name/-n option to makemigrations command #3090

Closed
wants to merge 1 commit into from

Conversation

rsalmaso
Copy link
Contributor

Add a --name option to makemigrations command
Refs https://code.djangoproject.com/ticket/23302

@@ -309,6 +309,11 @@ Note that this only works given two things:
that your database doesn't match your models, you'll just get errors when
migrations try to modify those tables.

If you want to give migration a meaningful name instead of generated one,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the migration(s)
a generated
This is probably better suited to be documented in docs/ref/django-admin.txt where all the options of makemigrations are mentioned.

@timgraham
Copy link
Member

I think it's too late in the release cycle to add this to 1.7. So it'll need a .. versionadded:: 1.8 annotation and release notes for 1.8.

The commit message should say "Fixed" not "Refs". See also our patch review checklist.

@rsalmaso rsalmaso changed the title Refs #23302 -- Added --name/-n option to makemigrations command Fixed #23302 -- Added --name/-n option to makemigrations command Aug 20, 2014
@rsalmaso
Copy link
Contributor Author

Updated PR
I'll add versionadded if #3091 will be not merged

@timgraham
Copy link
Member

Please do that and also rebase as it appears a conflicting change has been merged since this was submitted.

@rsalmaso
Copy link
Contributor Author

PR updated

@rsalmaso rsalmaso force-pushed the tickets/23302 branch 3 times, most recently from edef8c9 to db5f68d Compare August 26, 2014 06:02

.. django-admin-option:: --name, -n

The ``--name`` option give migration(s) a custom name instead of a generated one.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gives the

@timgraham
Copy link
Member

Please add 1.8 release notes and uncheck "Patch needs improvement" on the ticket when it's updated, thanks.

@rsalmaso
Copy link
Contributor Author

rsalmaso commented Sep 1, 2014

PR and ticket updated

@timgraham
Copy link
Member

buildbot, add to whitelist.

@timgraham
Copy link
Member

merged in 1435cfb, thanks.

@timgraham timgraham closed this Sep 3, 2014
@rsalmaso rsalmaso deleted the tickets/23302 branch September 3, 2014 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants