Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #23065 -- quote constraint names in SQL #3226

Closed
wants to merge 6 commits into from

Conversation

sir-sigurd
Copy link
Member

No description provided.

@timgraham
Copy link
Member

Can you add regression tests (and a mention in the 1.7.1 release notes)?

@sir-sigurd
Copy link
Member Author

yup, will be done tomorrow

@timgraham
Copy link
Member

buildbot, test this please.

@timgraham
Copy link
Member

The new test doesn't pass on Oracle:

Traceback (most recent call last):
  File "/home/jenkins/workspace/django-pull-requests/database/oracle11/python/python2.7/tests/schema/tests.py", line 1100, in test_remove_constraints_capital_letters
    "extra": "",
  File "/home/jenkins/workspace/django-pull-requests/database/oracle11/python/python2.7/django/db/backends/schema.py", line 101, in execute
    cursor.execute(sql, params)
  File "/home/jenkins/workspace/django-pull-requests/database/oracle11/python/python2.7/django/db/backends/utils.py", line 63, in execute
    return self.cursor.execute(sql, params)
  File "/home/jenkins/workspace/django-pull-requests/database/oracle11/python/python2.7/django/db/utils.py", line 95, in __exit__
    six.reraise(dj_exc_type, dj_exc_value, traceback)
  File "/home/jenkins/workspace/django-pull-requests/database/oracle11/python/python2.7/django/db/backends/utils.py", line 63, in execute
    return self.cursor.execute(sql, params)
  File "/home/jenkins/workspace/django-pull-requests/database/oracle11/python/python2.7/django/db/backends/oracle/base.py", line 918, in execute
    return self.cursor.execute(query, self._param_generator(params))
DatabaseError: ORA-01408: such column list already indexed

@sir-sigurd
Copy link
Member Author

test is fixed now

@timgraham
Copy link
Member

buildbot, test this please.

@timgraham
Copy link
Member

merged in 0bea6c8 and 83cd186, thanks!

@timgraham timgraham closed this Sep 23, 2014
@sir-sigurd sir-sigurd deleted the ticket_23065 branch November 24, 2014 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants