Ticket #15697 - Call get_models() with include_auto_created=True #346

Closed
wants to merge 1 commit into
from

4 participants

@ashchristopher

When we call get_models() without the include_auto_created=True
argument, we will not display indexes that are auto-created by django.
It will only show the indexes that are explicitly defined by the user.

@ashchristopher ashchristopher Call get_models() with include_auto_created=True
When we call get_models() without the include_auto_created=True
argument, we will not display indexes that are auto-created by django.
It will only show the indexes that are explicitly defined by the user.
d01486d
@nduthoit

Looks good to me 👍

@ptone
Django member

Looks good, but I'd move the tests to tests/regressiontests/admin_scripts/tests.py - its a bit of a monster file, but that is where all the admin script tests live currently - and it would be best not to create a brand new test app for this case. This is also worth a brief note in the release notes - while it would be an edge case, anyone doing anything automated with the output of those commands, could be surprised by the change in behavior.

@claudep
Django member

Thanks, fix pushed in 8010289

@claudep claudep closed this May 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment