Fixed null handling in Value expression #3850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarshwah
force-pushed
the
improve-value-expression
branch
from
3166131
to
133060a
Compare
| @@ -483,6 +483,8 @@ def __init__(self, value, output_field=None): | |||
| self.value = value | |||
|
|
|||
| def as_sql(self, compiler, connection): | |||
| if self.value is None: | |||
There was a problem hiding this comment.
Could you add a comment to explain the Oracle corner case? It would be good to know it without using git blame :)
jarshwah
force-pushed
the
improve-value-expression
branch
from
18e322f
to
a4db987
Compare
|
merged in 8713ea7, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases, Oracle is unable to convert
Value(None)into the correct NULL type, so we do it explicitly. #3825 has hit this corner case and has tests that fail without this change. Better to add this separately.