Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fixing auth basic tests #392

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

Testing method User.objects.create_user() without password param.

Member

ptone commented Sep 27, 2012

This was fixed in 8755fb1#diff-4

@ptone ptone closed this Sep 27, 2012

Look this: 8755fb1#L4R31

It is creating an user at variable u2 and is testing the variable u again, so the variable u2 is not being used/tested.

Member

ptone commented Sep 27, 2012

Though I had linked to the wrong commit - you are correct - while the code was altered in the recent 3011 work, it still contained the logic flaw.

70a0de3#L17L36

I'll land a fix shortly - thanks for the keen eye and followup.

@ptone ptone reopened this Sep 27, 2012

@ptone ptone closed this in 0136274 Sep 27, 2012

Owner

jezdez commented Sep 27, 2012

@ptone I'm pretty sure that doesn't fix #392. Please make sure to use Trac ticket IDs to reduce the number of wrong comments there (see https://code.djangoproject.com/ticket/392)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment