Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Ticket #4102 - Allow UPDATE of only specific fields in model.save() #4

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

niwinz commented Apr 28, 2012

It's the same patch that is on the ticket. - https://code.djangoproject.com/ticket/4102

(What a joy to have django on github officially)

Member

akaariai commented Apr 28, 2012

I will try to work on this ticket/pull request - limited time, unlimited amount of work and all that.

akaariai and others added some commits May 1, 2012

@akaariai akaariai Some improvements to niwibe's update_fields patch
The improvements are mostly stylistic cleanup. The non-stylistic
changes are:
  - update_fields can be any iterable. It will be converted to
    ImmutableSet internally so that signals can never alter it.
  - update_fields implies forced update, but not force_update. This
    is technically important, as force_update would result in updates
    even if there were no fields to update (possible in multitable
    situations).
  - Tests added for the above (and also otherwise).
  - Minor doc changes (mainly addition to releases/1.5.txt)
99cee28
@niwinz niwinz Merge pull request #1 from akaariai/ticket_4102_niwibe
Ticket 4102 niwibe
46954de
Member

akaariai commented May 1, 2012

I sent you a pull request for some updates into your patch, nothing big. I hope you can squash my update and your patch to one commit and update your branch to current Django head.

If you wish I can also do this myself by closing this pull request and opening another one from my repository.

To me it seems this feature is close to commit-ready. I think this one is big enough to require a review in Trac.

Contributor

niwinz commented May 1, 2012

It seems right.

@niwinz niwinz closed this May 1, 2012

Member

akaariai commented May 1, 2012

There is still the problem that you need to update your branch to current django/django head. And I would hope you could form a single patch/commit from the above.

Maybe the easiest way forward is to create a patch to Trac, then we could close this pull request and get a review for the patch in Trac, then again a new pull request and hopefully finally merged to django head.

I am not sure what is the best way forward, this git stuff is new to me, too...

Contributor

niwinz commented May 1, 2012

No problem, I create the patch and I will go to trac, and I will open another pull request with a single commit.

;)

@sztrovacsek sztrovacsek pushed a commit to sztrovacsek/django that referenced this pull request Mar 7, 2015

@jasonblum jasonblum Merge pull request #4 from evildmp/master
updaating
fced031

@sztrovacsek sztrovacsek pushed a commit to sztrovacsek/django that referenced this pull request Mar 7, 2015

@wherka wherka Merge pull request #4 from evildmp/master
Merge
d020b7c

@laddng laddng referenced this pull request Jun 20, 2016

Closed

Tutorial sample code typo #6812

@peterfarrell peterfarrell added a commit to atdsaa/django that referenced this pull request May 31, 2017

@djackson-saa @peterfarrell djackson-saa + peterfarrell # This is a combination of 3 commits.
# This is the 1st commit message:
Potential patch for reported issue

https://code.djangoproject.com/ticket/28170

# This is the commit message #2:

Fixed Flake8 Errors

# This is the commit message #3:

Another Fix for Flake8

# This is the commit message #4:

Updating copystat error handling.

Made these changes based on reviewer feedback.

# This is the commit message #5:

Added tests for copystat patch for CIFS filesystem

# This is the commit message #6:

Fixed Flake8 errors

# This is the commit message #7:

Fixed Flake8 errors

# This is the commit message #8:

Update to comments around copystat error handling

# This is the commit message #9:

Switching to access errno directory

# This is the commit message #10:

Correcting an if statement for errno

# This is the commit message #1:

various changes based on member suggestions.

# This is the commit message #2:

updating a comment to force a build.

# This is the commit message #3:

Removing unused decalred variables
72e42d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment