Fix issue #18267 - document `settings.configured` property. #43

Merged
merged 1 commit into from May 16, 2012

4 participants

@techtonik

Please, backport.

@ramiro
Django member

It would be nice if the configured var is properly marked up with the appropiate Sphinx in a way similar to configure(default_settings, **settings) in the same .txt file. This will allow it to be listed in module/symbols indexes and be cross-referenciable.

@adrianholovaty
Django member

There's a coding style issue here. There should be no space before or after the equals sign in "DEBUG=True".

@techtonik

Fixed this from web interface, but didn't run the build.

@techtonik

So, is it ok now?

@akaariai
Django member

I think you should do a "git rebase -i HEAD~4" to squash those commits into one. Then force-push the changes to your github branch.

I did a make html and checked the generated docs - looks good to me (though I am not a native English speaker...)

@techtonik
git rebase -i HEAD~4
git push -f

Updated. Wow. I am impressed.

@adrianholovaty
Django member

Thanks, techtonik!

@adrianholovaty adrianholovaty merged commit aa757ac into django:master May 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment