PEP8 fixes #474

Closed
wants to merge 1 commit into
from

4 participants

@camilonova

Fixed some PEP8 warnings about long lines

@camilonova camilonova PEP8 fixes
Fixed some PEP8 warnings about long lines
a9d73e7
@camilonova

@JanBednarik I did, and i agree with the longer lines, but this file is copied to the project folder when someone does 'collectstatic' and we make a pep8 check to the entire project giving us warnings about this file.

The proposed changes seems not affect the readability of the code and it will not look django as bad written.

Maybe other option should know why this .py file is copied as a static file, doesn't make any sense.

Any thoughts?

@lqc

You might want to report this as a bug. The staticfiles app just copies whatever it finds inside static directory (except for default ignores), so the compress.py gets included by mistake. IMHO, that file just shouldn't be there.

PS. You can always exclude your target directory for static files from pep8, as it shouldn't contain any relevant files anyway, right?. Or just put it outside your project root.

@camilonova

I have created a ticket for this:

https://code.djangoproject.com/ticket/19333

@aaugustin
Django member

This pull request is superseded by the ticket linked just above.

@aaugustin aaugustin closed this Nov 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment