Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #24125 -- Added a test to ensure that we can render the admindocs TemplateDetailView #4750

Closed
wants to merge 3 commits into from
Closed

Refs #24125 -- Added a test to ensure that we can render the admindocs TemplateDetailView #4750

wants to merge 3 commits into from

Conversation

kairichard
Copy link
Contributor

Without throwing an exception when using more than one Engine
This adds tests for 511a53b

Refs #24125.

Without throwing an exception when using more than one Engine
This adds a test for 511a53b

Refs #24125.
@timgraham
Copy link
Member

Please search for "#24125" in admindocs/views.py to see the places that need to be addressed.

@kairichard
Copy link
Contributor Author

I add new commit addressing all admindoc views

@timgraham
Copy link
Member

Are you aiming to add support for multiple engines or only to add these tests?

@kairichard
Copy link
Contributor Author

Actually I only wanted to add those tests as a regression. But since you it
might be a good idea to actually create another Ticket for multi-engine
support.
https://code.djangoproject.com/ticket/24957#ticket

On 8 June 2015 at 13:47, Tim Graham notifications@github.com wrote:

Are you aiming to add support for multiple engines or only to add these
tests?


Reply to this email directly or view it on GitHub
#4750 (comment).

@timgraham
Copy link
Member

In my mind, that's why #24125 is still open.

@kairichard
Copy link
Contributor Author

Ok, sorry, should have read more closely. So I would add a warning and
documentation if there is more than one engine. But I think that should
not be part of this PR.
Because this one just deals with adding missings tests for changes to the
admindocs from the following commits:
655f524#diff-b08680e8c8451c804eb8b58220e8b3d5
and
511a53b#diff-b08680e8c8451c804eb8b58220e8b3d5

OTOH: Would you say multiple engines should be supported?

On 8 June 2015 at 21:42, Tim Graham notifications@github.com wrote:

In my mind, that's why #24125 is still open.


Reply to this email directly or view it on GitHub
#4750 (comment).

@timgraham timgraham changed the title Add a test to ensure that we can render the TemplateDetailView #djangocon-sprints Refs #24125 -- Added a test to ensure that we can render the admindocs TemplateDetailView Jun 9, 2015
@timgraham
Copy link
Member

We can merge these tests and keep the ticket open to support multiple engines (if you or anyone else cares to implement that).

@timgraham
Copy link
Member

merged in 3c593ba, thanks!

@timgraham timgraham closed this Jun 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants