Comment._get_userinfo thread safe #50

merged 1 commit into from May 8, 2012


None yet

2 participants


This pull request is a small fix for Comment._get_userinfo of the django.contrib.comments app. The code was not re-entrant, normally this should not required but I had to fix it because of this other issue in django-debug-toolbar: jazzband/django-debug-toolbar#281

Django member

Seems like a good idea regardless of threadsafety, now the dict won't be partially populated if an exception occurs.

@alex alex merged commit 1b05546 into django:master May 8, 2012

indeed that's the real reason, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment